Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libffi to 3.2 #3183

Merged
merged 3 commits into from Nov 26, 2014
Merged

Update libffi to 3.2 #3183

merged 3 commits into from Nov 26, 2014

Conversation

gustavotemple
Copy link
Contributor

Update libffi from 3.0.13 to 3.2

@yorickpeterse
Copy link
Contributor

This currently breaks the build due to configure not being executable by the looks of it. Also, updating libffi is sadly not a trivial task: #3137

@gustavotemple
Copy link
Contributor Author

@yorickpeterse, sorry about that, I fixed and it worked fine.
I've been using the libffi 3.1 for some time, to make sure it works, and is working well in my environment.

@yorickpeterse
Copy link
Contributor

Ah, thanks. If I recall there are also some custom changes we've made to libffi (#3137 (comment)). We'll need to make sure those are either re-applied or simply no longer needed.

@gustavotemple
Copy link
Contributor Author

@yorickpeterse, I did a diff and I saw that the only modification is the removal of FFI_MMAP_EXEC_SELINUX macro.
You want that I do some specific test to see if this modification is still necessary?

@yorickpeterse
Copy link
Contributor

Apparently that macro was disabled in 06e672b. I'm not sure if we still need this. @brixen @dbussink any thoughts on this?

@dbussink
Copy link
Contributor

@yorickpeterse Was gone on vacation to 🇯🇵, but yeah, we still need that macro. Otherwise FFI tries to enable workarounds when SELinux is enabled for executable memory that breaks stuff. We need executable memory anyway for the JIT so it doesn't change any requirements.

@yorickpeterse
Copy link
Contributor

Aha, I had a hunch that might've been the case. @gustavotemple could you re-apply the patch discussed in 06e672b and add that to the PR? Once done it should probably be good to go.

Gustavo Frederico Temple Pedrosa added 2 commits November 11, 2014 12:18
Update libffi from 3.0.13 to 3.1
We disable this on Rubinius since it causes crashes. The JIT
needs to be able to create these mappings anyway, so it doesn't
create an additional depedency in FFI.
@gustavotemple
Copy link
Contributor Author

@yorickpeterse, @dbussink, @brixen, I submitted the both commits and they were builded OK.

@dbussink
Copy link
Contributor

Also looks like 3.2 was released just today, maybe makes sense to immediately update to that. Also the MMAP workaround only seems to add comments, so I wonder if that is still enabled in libffi.

@gustavotemple gustavotemple changed the title Update libffi to 3.1 Update libffi to 3.2 Nov 11, 2014
Update libffi from 3.1 to 3.2
@gustavotemple
Copy link
Contributor Author

@dbussink: Done !

@brixen
Copy link
Member

brixen commented Nov 26, 2014

@gustavotemple thanks for working on this!

brixen added a commit that referenced this pull request Nov 26, 2014
@brixen brixen merged commit d8e2557 into rubinius:master Nov 26, 2014
@gustavotemple
Copy link
Contributor Author

@brixen: welcome! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants