-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update libffi to 3.2 #3183
Update libffi to 3.2 #3183
Conversation
This currently breaks the build due to |
@yorickpeterse, sorry about that, I fixed and it worked fine. |
Ah, thanks. If I recall there are also some custom changes we've made to libffi (#3137 (comment)). We'll need to make sure those are either re-applied or simply no longer needed. |
@yorickpeterse, I did a |
@yorickpeterse Was gone on vacation to 🇯🇵, but yeah, we still need that macro. Otherwise FFI tries to enable workarounds when SELinux is enabled for executable memory that breaks stuff. We need executable memory anyway for the JIT so it doesn't change any requirements. |
Aha, I had a hunch that might've been the case. @gustavotemple could you re-apply the patch discussed in 06e672b and add that to the PR? Once done it should probably be good to go. |
Update libffi from 3.0.13 to 3.1
We disable this on Rubinius since it causes crashes. The JIT needs to be able to create these mappings anyway, so it doesn't create an additional depedency in FFI.
@yorickpeterse, @dbussink, @brixen, I submitted the both commits and they were builded OK. |
Also looks like 3.2 was released just today, maybe makes sense to immediately update to that. Also the MMAP workaround only seems to add comments, so I wonder if that is still enabled in libffi. |
Update libffi from 3.1 to 3.2
@dbussink: Done ! |
@gustavotemple thanks for working on this! |
@brixen: welcome! :) |
Update libffi from 3.0.13 to 3.2