Test that all of the supported RDF response types work #325
Conversation
| throws ClientProtocolException, IOException { | ||
| final HttpResponse response = execute(method); | ||
| final int result = response.getStatusLine().getStatusCode(); | ||
| assertEquals(OK.getStatusCode(), response.getStatusLine().getStatusCode()); |
There was a problem hiding this comment.
Please use the "result" variable from line:127 here in line:128.
|
@cjcolvar, I have rebased your work on master and sent you the following PR: Did you know/expect the new tests that you added would not pass? It would be great if you could update the tests and functional code to be in line, before this PR can be merged. |
|
Where does this stand, @cjcolvar? |
|
Last I worked on it I think I had most tests passing, but was confused about retrieving specific versions of nodes. I'll try to take a look at this over the weekend. |
|
@awoods This should be good to go now. Sorry about the delay. The rest api docs for GET accepts will need to be updated/verified that they match the tested list: https://github.com/cjcolvar/fcrepo4/blob/search-accept-rdfjson/fcrepo-http-commons/src/main/java/org/fcrepo/http/commons/domain/RDFMediaType.java#L80-L81 |
Test that all of the supported RDF response types work Resolves: https://www.pivotaltracker.com/story/show/71234752
|
Please update the wiki as you recommended above, @cjcolvar. |
|
@awoods I finally updated the wiki. All of the accept request headers in the documentation (not the examples) have been corrected, verified, and alphabetized. |
The fcr:search endpoint in the code claimed to be able to return application/xml but jena doesn't support serializing Dataset to that content type. The wiki REST documentation claims other types (application/n3 and application/rdf+json) are supported but they run into the same problem. These tests check that the supported return types actually can be returned. The wiki REST documentation needs to be updated to reflect the reality proven by these tests. Fixes #320.