Fnmatch extglob support #2275
Fnmatch extglob support #2275
Conversation
|
Ugh, sorry for the "trailing white space removal" noise 😦 |
| @@ -466,6 +466,84 @@ private static int push_globs(POSIX posix, String cwd, List<ByteList> ary, byte[ | |||
| return glob_helper(posix, cwd, pattern, pbegin, pend, -1, pflags, glob_caller, new GlobArgs(push_pattern, ary)); | |||
| } | |||
|
|
|||
| public static ArrayList<String> braces(String pattern, int flags, ArrayList<String> patterns) { | |||
There was a problem hiding this comment.
If I can swap String pattern for ByteList pattern then I can ditch spath above. Need some guidance on String -> ByteList though.
Thanks @jbr for expanding these.
|
It would be nice w/o the whitespace, but I'd like to test this patch out |
|
@jc00ke If you can, please do remove the whitespace. Should be simple enough to reset the commit and only add -p the relevant lines, plus force push. |
|
Alternatively I could just remove it manually when I merge PR. Testing locally now. |
|
I'll fix it real quick. |
|
I confirmed that the two MRI tests for FNM_EXTGLOB are good too, ruby/test_fnmatch.rb in test_extglob and test_unmatched_encoding. So I'm satisfied that this is good to merge (sans whitespace noise). |
|
@headius whitespace removal begone! 😉 |
|
🎉 now to test it ;) |
|
Do work @zzak! |
|
Thanks for the help, all :-) |
Closes #721