small optimizations

mojolicious · Dec 5, 2012 · a94d2e1 · a94d2e1
1 parent cf3ce52
commit a94d2e1
Show file tree

Hide file tree

Showing 9 changed files with 13 additions and 27 deletions.
diff --git a/lib/Mojo/ByteStream.pm b/lib/Mojo/ByteStream.pm
@@ -34,10 +34,7 @@ sub new {
 
 sub b { __PACKAGE__->new(@_) }
 
-sub clone {
-  my $self = shift;
-  return $self->new($$self);
-}
+sub clone { $_[0]->new(${$_[0]}) }
 
 sub decode {
   my $self = shift;
@@ -59,14 +56,14 @@ sub say {
 
 sub secure_compare { Mojo::Util::secure_compare ${shift()}, @_ }
 
-sub size { length ${shift()} }
+sub size { length ${$_[0]} }
 
 sub split {
   my ($self, $pattern) = @_;
   return Mojo::Collection->new(map { $self->new($_) } split $pattern, $$self);
 }
 
-sub to_string { ${shift()} }
+sub to_string { ${$_[0]} }
 
 1;
 

diff --git a/lib/Mojo/IOLoop.pm b/lib/Mojo/IOLoop.pm
@@ -161,10 +161,7 @@ sub start {
   (ref $self ? $self : $self->singleton)->reactor->start;
 }
 
-sub stop {
-  my $self = shift;
-  (ref $self ? $self : $self->singleton)->reactor->stop;
-}
+sub stop { (ref $_[0] ? $_[0] : $_[0]->singleton)->reactor->stop }
 
 sub stream {
   my ($self, $stream) = @_;

diff --git a/lib/Mojo/IOLoop/Server.pm b/lib/Mojo/IOLoop/Server.pm
@@ -110,10 +110,7 @@ sub start {
     $self->{handle} => sub { $self->_accept for 1 .. $self->multi_accept });
 }
 
-sub stop {
-  my $self = shift;
-  $self->reactor->remove($self->{handle});
-}
+sub stop { $_[0]->reactor->remove($_[0]->{handle}) }
 
 sub _accept {
   my $self = shift;

diff --git a/lib/Mojo/JSON.pm b/lib/Mojo/JSON.pm
@@ -240,7 +240,8 @@ sub _decode_value {
 }
 
 sub _encode_array {
-  return '[' . join(',', map { _encode_values($_) } @{shift()}) . ']';
+  my $array = shift;
+  return '[' . join(',', map { _encode_values($_) } @$array) . ']';
 }
 
 sub _encode_object {

diff --git a/lib/Mojo/Reactor/Poll.pm b/lib/Mojo/Reactor/Poll.pm
@@ -69,7 +69,7 @@ sub recurring { shift->_timer(1, @_) }
 
 sub remove {
   my ($self, $remove) = @_;
-  return !!delete shift->{timers}{shift()} unless ref $remove;
+  return !!delete $self->{timers}{$remove} unless ref $remove;
   $self->_poll->remove($remove);
   return !!delete $self->{io}{fileno $remove};
 }

diff --git a/lib/Mojo/Transaction.pm b/lib/Mojo/Transaction.pm
@@ -77,10 +77,7 @@ sub server_close {
 sub server_read  { croak 'Method "server_read" not implemented by subclass' }
 sub server_write { croak 'Method "server_write" not implemented by subclass' }
 
-sub success {
-  my $self = shift;
-  return $self->error ? undef : $self->res;
-}
+sub success { $_[0]->error ? undef : $_[0]->res }
 
 1;
 

diff --git a/lib/Mojo/Transaction/WebSocket.pm b/lib/Mojo/Transaction/WebSocket.pm
@@ -253,7 +253,7 @@ sub server_write {
   return delete $self->{write} // '';
 }
 
-sub _challenge { b64_encode(sha1_bytes((pop() || '') . GUID), '') }
+sub _challenge { b64_encode(sha1_bytes(($_[1] || '') . GUID), '') }
 
 sub _message {
   my ($self, $frame) = @_;

diff --git a/lib/Mojo/UserAgent.pm b/lib/Mojo/UserAgent.pm
@@ -361,10 +361,7 @@ sub _handle {
   $self->ioloop->stop if !$self->{nb} && !keys %{$self->{connections}};
 }
 
-sub _loop {
-  my $self = shift;
-  return $self->{nb} ? Mojo::IOLoop->singleton : $self->ioloop;
-}
+sub _loop { $_[0]->{nb} ? Mojo::IOLoop->singleton : $_[0]->ioloop }
 
 sub _read {
   my ($self, $id, $chunk) = @_;

diff --git a/lib/Mojo/Util.pm b/lib/Mojo/Util.pm
@@ -48,9 +48,9 @@ our @EXPORT_OK = (
   qw(url_escape url_unescape xml_escape xor_encode)
 );
 
-sub b64_decode { decode_base64(shift) }
+sub b64_decode { decode_base64($_[0]) }
 
-sub b64_encode { encode_base64(shift, shift) }
+sub b64_encode { encode_base64($_[0], $_[1]) }
 
 sub camelize {
   my $string = shift;