fixed a few "0" value bugs in Mojo::DOM::HTML

mojolicious · Nov 17, 2013 · 0de0c92 · 0de0c92
1 parent 7842d0a
commit 0de0c92
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/Changes b/Changes
@@ -1,9 +1,10 @@
 
-4.58  2013-11-16
+4.58  2013-11-17
   - Improved IIS and WebSphere compatibility of Mojo::Message::Request.
   - Improved Mojo::DOM::HTML performance.
   - Fixed recursion bug in Mojo::Reactor::EV where timers could run more than
     once.
+  - Fixed a few "0" value bugs in Mojo::DOM::HTML.
 
 4.57  2013-11-11
   - Improved compatibility with IO::Socket::SSL 1.957.

diff --git a/lib/Mojo/DOM/HTML.pm b/lib/Mojo/DOM/HTML.pm
@@ -99,16 +99,16 @@ sub parse {
     push @$current, ['text', html_unescape $text] if length $text;
 
     # DOCTYPE
-    if ($doctype) { push @$current, ['doctype', $doctype] }
+    if (defined $doctype) { push @$current, ['doctype', $doctype] }
 
     # Comment
-    elsif ($comment) { push @$current, ['comment', $comment] }
+    elsif (defined $comment) { push @$current, ['comment', $comment] }
 
     # CDATA
-    elsif ($cdata) { push @$current, ['cdata', $cdata] }
+    elsif (defined $cdata) { push @$current, ['cdata', $cdata] }
 
     # Processing instruction (try to detect XML)
-    elsif ($pi) {
+    elsif (defined $pi) {
       $self->xml(1) if !defined $self->xml && $pi =~ /xml/i;
       push @$current, ['pi', $pi];
     }

diff --git a/t/mojo/dom.t b/t/mojo/dom.t
@@ -2206,6 +2206,10 @@ $dom = Mojo::DOM->new('0');
 is "$dom", '0', 'right result';
 $dom->append_content('☃');
 is "$dom", '0☃', 'right result';
+is $dom->parse('<!DOCTYPE 0>'),  '<!DOCTYPE 0>',  'successful roundtrip';
+is $dom->parse('<!--0-->'),      '<!--0-->',      'successful roundtrip';
+is $dom->parse('<![CDATA[0]]>'), '<![CDATA[0]]>', 'successful roundtrip';
+is $dom->parse('<?0?>'),         '<?0?>',         'successful roundtrip';
 
 # Comments
 $dom = Mojo::DOM->new(<<EOF);