Remove AddThis by default #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Despite the fact that a lot of people does not like the Addthis button, it is widely spread across Nikola sites... so, I am inclined to thinking about the removal as a change to be done till v8. |
|
there, marked as such. Though we could also find a prettier alternative (and one that looks sane without JS) |
👍 to this idea... |
|
In other news: addthis is evil. |
|
I repeat myself, I am 👍 on removing it (and I had to remove it from my site too, btw...) |
Kwpolska
force-pushed
the
master
branch
2 times, most recently
from
fefe9b6
to
1ee0ed7
Compare
|
👍 to removing this. |
|
Let's just kill it. |
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
|
Ignoring the release cycle? Awesome! Merging now (also fixing a leftover from |
Kwpolska
force-pushed
the
remove-addthis
branch
from
3f6be06
to
aaa2190
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove AddThis, as discussed on the ML.
This might not be the perfect time to do it, it might need to wait till v8. Opinions?