Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 75c938bebd1a
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6f416d89c5f9
Choose a head ref
  • 2 commits
  • 4 files changed
  • 1 contributor

Commits on Oct 27, 2014

  1. Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    nomadium Miguel Landaeta
    Copy the full SHA
    ebc3eb8 View commit details
  2. Revert "[Truffle] Tag a couple of failing PE tests."

    This reverts commit c55e310.
    eregon committed Oct 27, 2014

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    nomadium Miguel Landaeta
    Copy the full SHA
    6f416d8 View commit details
Showing with 4 additions and 2 deletions.
  1. +1 −0 test/pom.rb
  2. +1 −0 test/pom.xml
  3. +1 −1 test/truffle/pe/core/hash_pe.rb
  4. +1 −1 test/truffle/pe/macro/pushing_pixels_pe.rb
1 change: 1 addition & 0 deletions test/pom.rb
Original file line number Diff line number Diff line change
@@ -252,6 +252,7 @@
'<arg value="-J-G:-TruffleBackgroundCompilation" />' +
'<arg value="-J-G:+TruffleCompilationExceptionsAreFatal" />' +
'<arg value="-X+T" />' +
'<arg value="-Xtruffle.proc.binding=false" />' +
'<arg value="-Xtruffle.debug.enable_assert_constant=true" />' +
'<arg value="test/truffle/pe/pe.rb" />' +
'</exec>' +
1 change: 1 addition & 0 deletions test/pom.xml
Original file line number Diff line number Diff line change
@@ -369,6 +369,7 @@
<arg value="-J-G:-TruffleBackgroundCompilation" />
<arg value="-J-G:+TruffleCompilationExceptionsAreFatal" />
<arg value="-X+T" />
<arg value="-Xtruffle.proc.binding=false" />
<arg value="-Xtruffle.debug.enable_assert_constant=true" />
<arg value="test/truffle/pe/pe.rb" />
</exec>
2 changes: 1 addition & 1 deletion test/truffle/pe/core/hash_pe.rb
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@
truffle_assert_constant hash[:b]
end

broken_example "mapped to an Array and indexed by a constant" do
example "mapped to an Array and indexed by a constant" do
hash = {a: 0, b: 1, c: 2}
array = hash.map { |k, v| v }
truffle_assert_constant array[0]
2 changes: 1 addition & 1 deletion test/truffle/pe/macro/pushing_pixels_pe.rb
Original file line number Diff line number Diff line change
@@ -29,7 +29,7 @@ def method_missing(method, *args)

PETests.tests do

broken_example "A set of constants used in a literal hash, mapped to an array, indexed, used in an array literal, sorted, indexed, and added, all via method_missing, respond_to? and send" do
example "A set of constants used in a literal hash, mapped to an array, indexed, used in an array literal, sorted, indexed, and added, all via method_missing, respond_to? and send" do
bar = PushingPixelsFixtures::Bar.new
truffle_assert_constant bar.foo(14, 8, 6)
end