Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 39dfe9468206
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 8e190bf6a13f
Choose a head ref
  • 12 commits
  • 10 files changed
  • 5 contributors

Commits on Apr 15, 2013

  1. os: fix unlikely buffer overflow in os.type()

    * Fix a buffer overflow that happens iff strlen(info.sysname) > 255.
    * Check the return value of uname().
    bnoordhuis committed Apr 15, 2013
    Copy the full SHA
    78c5de5 View commit details
    Browse the repository at this point in the history
  2. os: handle 256 character hostnames

    Fix a (rather academic) buffer overflow. MAXHOSTNAMELEN is 256 on most
    platforms, which means the buffer wasn't big enough to hold the
    trailing nul byte on a system with a maximum length hostname.
    bnoordhuis committed Apr 15, 2013
    Copy the full SHA
    afbadde View commit details
    Browse the repository at this point in the history
  3. os: unbreak windows build

    Windows doesn't have MAXHOSTNAMELEN. Introduced in afbadde.
    bnoordhuis committed Apr 15, 2013
    Copy the full SHA
    d58ee7e View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2013

  1. test: preserve process.env in forked child_process

    When LD_LIBRARY_PATH is overriden for custom builds we need to preserve
    it for forked process. There are possibly other environment variables
    that could cause test failures so we preserve whole environment of
    parent process.
    Stanislav Ochotnicky authored and bnoordhuis committed Apr 16, 2013
    Copy the full SHA
    47198af View commit details
    Browse the repository at this point in the history
  2. test: preserve process.env after test-init exec

    When LD_LIBRARY_PATH is overriden for custom builds we need to preserve
    it for child processes. To be sure we preserve whole environment of
    parent process and just add TEST_INIT variable to it.
    Stanislav Ochotnicky authored and bnoordhuis committed Apr 16, 2013
    Copy the full SHA
    7592615 View commit details
    Browse the repository at this point in the history
  3. handle_wrap: fix NULL pointer dereference

    Fix a NULL pointer dereference in src/handle_wrap.cc which is really a
    use-after-close bug.
    
    The test checks that unref() after close() works on process.stdout but
    this bug affects everything that derives from HandleWrap. I discovered
    it because child processes would sometimes quit for no reason (that is,
    no reason until I turned on core dumps.)
    bnoordhuis committed Apr 16, 2013
    2
    Copy the full SHA
    ccd3722 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    b02b93b View commit details
    Browse the repository at this point in the history
  5. docs: update path.join() example for v0.10

    The current example shows the behavior of v0.8. In v0.10 arguments
    to path.join() must be strings; otherwise, an exception is thrown.
    kellygerber authored and bnoordhuis committed Apr 16, 2013
    Copy the full SHA
    36503b5 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2013

  1. test: make stdout-close-unref work in test runner

    process.stdout isn't fully initialized yet by the time the test starts
    when invoked with `python tools/test.py`. Use process.stdin instead and
    force initialization with process.stdin.resume().
    bnoordhuis committed Apr 17, 2013
    Copy the full SHA
    2e70dda View commit details
    Browse the repository at this point in the history
  2. dgram: fix no address bind()

    I broke dgram.Socket#bind(port, cb) almost a year ago in 332fea5 but
    it wasn't until today that someone complained and none of the tests
    caught it because they all either specify the address or omit the
    callback.
    
    Anyway, now it works again and does what you expect: it binds the
    socket to the "any" address ("0.0.0.0" for IPv4 and "::" for IPv6.)
    bnoordhuis committed Apr 17, 2013
    Copy the full SHA
    92023b4 View commit details
    Browse the repository at this point in the history
  3. crypto: fix return Local Handle w/o scope.Close()

    A new String was being created and returned, but was not sent through
    the scope.Close(), which caused it to be cleaned up before being
    returned.
    trevnorris authored and bnoordhuis committed Apr 17, 2013
    Copy the full SHA
    659fb23 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2013

  1. Merge remote-tracking branch 'origin/v0.10'

    Conflicts:
    	src/node_os.cc
    bnoordhuis committed Apr 18, 2013
    Copy the full SHA
    8e190bf View commit details
    Browse the repository at this point in the history