Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: b8a7eedea32d
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: b26d346b57fc
Choose a head ref
  • 12 commits
  • 157 files changed
  • 8 contributors

Commits on Jul 30, 2013

  1. docs: Warning about consuming response

    geek authored and isaacs committed Jul 30, 2013
    Copy the full SHA
    6359e01 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2013

  1. http: improve chunked res.write(buf) performance

    Avoid a costly buffer-to-string operation. Instead, allocate a new
    buffer, copy the chunk header and data into it and send that.
    
    The speed difference is negligible on small payloads but it really
    shines with larger (10+ kB) chunks. benchmark/http/end-vs-write-end
    with 64 kB chunks gives 45-50% higher throughput. With 1 MB chunks,
    the difference is a staggering 590%.
    
    Of course, YMMV will vary with real workloads and networks but this
    commit should have a positive impact on CPU and memory consumption.
    
    Big kudos to Wyatt Preul (@wpreul) for reporting the issue and providing
    the initial patch.
    
    Fixes #5941 and #5944.
    bnoordhuis committed Jul 31, 2013
    3
    Copy the full SHA
    3398cce View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2013

  1. events: fix memory leak, don't leak event names

    Before this commit, events were set to undefined rather than deleted
    from the EventEmitter's backing dictionary for performance reasons:
    `delete obj.key` causes a transition of the dictionary's hidden class
    and that can be costly.
    
    Unfortunately, that introduces a memory leak when many events are added
    and then removed again. The strings containing the event names are never
    reclaimed by the garbage collector because they remain part of the
    dictionary.
    
    That's why this commit makes EventEmitter delete events again. This
    effectively reverts commit 0397223.
    
    Fixes #5970.
    bnoordhuis committed Aug 1, 2013
    Copy the full SHA
    fc6f8a6 View commit details
    Browse the repository at this point in the history
  2. test: fix pummel/test-net-connect-memleak

    * Run the garbage collector before creating the big array. It doesn't
      matter now but if in the future something in node.js core creates
      a lot of reclaimable garbage, that will break the test's expectation.
    
    * The first RSS check was being done too late. The garbage collector
      might have run before the check, throwing off the 'reclaimed memory'
      calculation.
    
    * Due to changes in how V8 represents the big array internally, the
      actual memory usage is just below 256 MB on x64. Update the test's
      expectation.
    bnoordhuis committed Aug 1, 2013
    Copy the full SHA
    98db7ba View commit details
    Browse the repository at this point in the history
  3. test: future-proof simple/test-event-emitter-memory-leak

    Run the garbage collector before running the actual test. It doesn't
    matter now but if in the future something in node.js core creates a lot
    of reclaimable garbage, that will break the test's expectation.
    bnoordhuis committed Aug 1, 2013
    Copy the full SHA
    9e1eb36 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2013

  1. npm: Upgrade to 1.3.7

    isaacs committed Aug 2, 2013
    Copy the full SHA
    bea9dfa View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2013

  1. doc: fs.open, fix flag/mode confusion, etc.

    Flags and modes aren't the same, symlinks are followed in all of the
    path but the last component, docs should say something about what the
    mode argument is for and when its used, fs.openSync should point to the
    function that contains the docs for its args, as fs.writeSync does.
    sam-github authored and bnoordhuis committed Aug 5, 2013
    Copy the full SHA
    6a7be99 View commit details
    Browse the repository at this point in the history
  2. doc: document domain.enter() and domain.exit()

    Adds the documentation requested in #5017.
    othiym23 authored and bnoordhuis committed Aug 5, 2013
    Copy the full SHA
    231092d View commit details
    Browse the repository at this point in the history
  3. v8: back-port fix for CVE-2013-2882

    Quoting the CVE:
    
        Google V8, as used in Google Chrome before 28.0.1500.95, allows
        remote attackers to cause a denial of service or possibly have
        unspecified other impact via vectors that leverage "type confusion."
    
    Likely has zero impact on node.js because it only runs local, trusted
    code but let's apply it anyway.
    
    This is a back-port of upstream commit r15665. Original commit log:
    
        Use internal array as API function cache.
    
        R=yangguo@chromium.org
        BUG=chromium:260106
        TEST=cctest/test-api/Regress260106
    
        Review URL: https://codereview.chromium.org/19159003
    
    Fixes #5973.
    mstarzinger@chromium.org authored and bnoordhuis committed Aug 5, 2013
    Copy the full SHA
    6b92a71 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    366baed View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2013

  1. stream: Fix double pipe error emit

    If an error listener is added to a stream using once() before it is
    piped, it is invoked and removed during pipe() but before pipe() sees it
    which causes it to be emitted again.
    
    Fixes #4155 #4978
    Eran Hammer authored and isaacs committed Aug 6, 2013
    Copy the full SHA
    23d92ec View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'upstream/v0.10'

    Conflicts:
    	deps/v8/test/cctest/test-api.cc
    	lib/events.js
    	lib/http.js
    tjfontaine committed Aug 6, 2013
    Copy the full SHA
    b26d346 View commit details
    Browse the repository at this point in the history