Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added better IT tests for binary content #28

Closed
wants to merge 4 commits into from
Closed

added better IT tests for binary content #28

wants to merge 4 commits into from

Conversation

acoburn
Copy link
Contributor

@acoburn acoburn commented Dec 30, 2014

This partially addresses https://jira.duraspace.org/browse/FCREPO-1269

This commit added better IT tests for binaries and containers

It also adds much imporved integration tests with an external triplestore and an external Solr instance

renamed Namespaces class so as not to conflict with the o.a.c.builder.xml.Namespaces class

What remains for the JIRA issue is some OSGi testing.

acoburn and others added 3 commits December 30, 2014 17:02
added better IT tests for containers

added better integration tests with an external triplestore

added solr integration tests

renamed Namespaces class so as not to conflict with the o.a.c.builder.xml.Namespaces class
@@ -40,7 +40,8 @@ public void process(final Exchange exchange) throws IOException {
final Message in = exchange.getIn();
final String subject = ProcessorUtils.getSubjectUri(in);

in.setBody("DELETE WHERE { <" + subject + "> ?p ?o }");
in.setBody("DELETE WHERE { <" + subject + "> ?p ?o };\n" +
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a (valid) hack for plucking out specific triples. If so, please add a comment to the effect of why you are requiring the fcr:export path element. There is a good chance that the jcr/xml export may be going away at some point, and it is important that we know if this line of code is a true dependency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@awoods I'll add a note to this effect.

@awoods
Copy link

awoods commented Jan 6, 2015

Resolved with: a361ca1

@awoods awoods closed this Jan 6, 2015
@acoburn acoburn deleted the better-integration-tests branch January 8, 2015 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants