https://tickets.openmrs.org/browse/TRUNK-15Trunk 15 #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe what you have provided is not what we are looking for. You provided two files: trunk-15 and TRUNK-15. They appear to be classes or code snippets, but would not be compiled into anything meaningful in the code. I think you have the right idea but need to actually change the files you want to affect, compile the changes and possibly write some unit tests to support the ticket. Please ask in IRC, as you have been doing, and in the mailing list if you need more guidance. Thanks. |
RandilaP
pushed a commit
to RandilaP/openmrs-core
that referenced
this pull request
Jul 31, 2023
* (feat) Add options parameter to translateFrom * Fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all comments are welcome to help me sort this ticket