Fix #14420: system warning in make_captcha

dregad · dregad · commit 15251868dc02 · 2012-06-26T12:53:01.000+02:00
Per PHP documentation [1], second param of imagejpeg() should be set to null to output the image directly. Thanks to Andrew Kovalenko for noticing and providing fix for the issue [1] http://php.net/imagejpeg
diff --git a/make_captcha_img.php b/make_captcha_img.php
@@ -256,7 +256,7 @@ function make_captcha( $private_key )
 				$x += (int)($size + ($this->minsize / 5));
 			}
 			header('Content-type: image/jpeg');
-			@ImageJPEG($image, '', $this->jpegquality);
+			@ImageJPEG($image, null, $this->jpegquality);
 			@ImageDestroy($image);
 			if($this->debug) echo "\n<br />-Captcha-Debug: Destroy Imagestream.";
 		}

Original file line number	Diff line number	Diff line change
`@@ -256,7 +256,7 @@ function make_captcha( $private_key )`
`256`	`256`	`$x += (int)($size + ($this->minsize / 5));`
`257`	`257`	`}`
`258`	`258`	`header('Content-type: image/jpeg');`
`259`		`- @ImageJPEG($image, '', $this->jpegquality);`
	`259`	`+ @ImageJPEG($image, null, $this->jpegquality);`
`260`	`260`	`@ImageDestroy($image);`
`261`	`261`	`if($this->debug) echo "\n<br />-Captcha-Debug: Destroy Imagestream.";`
`262`	`262`	`}`