[fix] abstract out the creating of the reactor and allow server.add t…

…o add the reactor to the running set
nodejitsu · Dec 1, 2013 · eed25a5 · eed25a5
1 parent f6dd769
commit eed25a5
Showing 1 changed file with 26 additions and 8 deletions.
diff --git a/lib/godot/net/server.js b/lib/godot/net/server.js
@@ -73,6 +73,17 @@ Server.prototype.add = function (reactor) {
   reactor.on('error', this.emit.bind(this, 'error'));
   reactor.on('reactor:error', this.emit.bind(this, 'reactor:error'));
   this.reactors[reactor.id] = reactor;
+  //
+  // Add reactor to the running set
+  // Remark: there will only be one host
+  //
+  var keys = Object.keys(this.hosts);
+  if (keys.length) {
+    for(var i=0; i<keys.length; i++) {
+      this.hosts[keys[i]].push(this.createReactor(reactor.id));
+    }
+  }
+
 };
 
 //
@@ -198,6 +209,20 @@ Server.prototype.close = function (callback) {
     : this.server.close();
 };
 
+//
+// ### function createReactor
+// #### @id {UUID} Reactor id
+// Returns a source and dest stream object that
+// the socket ends up writing to
+//
+Server.prototype.createReactor = function (id) {
+  var source = new ReadWriteStream();
+  return {
+    dest: this.reactors[id].createStream(source),
+    source: source
+  };
+};
+
 //
 // ### function createReactors (id)
 // #### @id {string} `host:port` id for these reactors.
@@ -213,14 +238,7 @@ Server.prototype.createReactors = function (id) {
     }
 
     this.hosts[id] = Object.keys(this.reactors)
-      .reduce(function (all, key) {
-        var source = new ReadWriteStream();
-        all.push({
-          dest: self.reactors[key].createStream(source),
-          source: source
-        });
-        return all;
-      }, []);
+      .map(this.createReactor.bind(this));
   }
 };