New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed typo in the name of an Element. #58
Conversation
@@ -472,7 +472,7 @@ public static Elements ofString(final String str) { | |||
public final static IElement PROTACTINIUM = Protactinium.toIElement(); | |||
public final static IElement URANIUM = Uranium.toIElement(); | |||
public final static IElement NEPTUNIUM = Neptunium.toIElement(); | |||
public final static IElement PLUTOMNIUM = Plutonium.toIElement(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the following to avoid the API change - not that many people would likely be using this. thanks
@Deprecated
PLUTOMNIUM = PLUTONIUM;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, made change and added another commit for CAS Numbers, but may have some formatting changes. Sorry about that...
From: John May
Sent: Wednesday, September 03, 2014 6:14 PM
To: cdk/cdk
Cc: mbv31602
Subject: Re: [cdk] fixed typo in the name of an Element. (#58)
In base/core/src/main/java/org/openscience/cdk/config/Elements.java:
@@ -472,7 +472,7 @@ public static Elements ofString(final String str) {
public final static IElement PROTACTINIUM = Protactinium.toIElement();
public final static IElement URANIUM = Uranium.toIElement();
public final static IElement NEPTUNIUM = Neptunium.toIElement();
- public final static IElement PLUTOMNIUM = Plutonium.toIElement();
Could you add the following to avoid the API change - not that many people would likely be using this. thanks
@deprecated
PLUTOMNIUM = PLUTONIUM;
—
Reply to this email directly or view it on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some editing problem with the second file, removed {s, hold off for now, I will fix it up. Just drop this pull request.
From: John May
Sent: Wednesday, September 03, 2014 6:14 PM
To: cdk/cdk
Cc: mbv31602
Subject: Re: [cdk] fixed typo in the name of an Element. (#58)
In base/core/src/main/java/org/openscience/cdk/config/Elements.java:
@@ -472,7 +472,7 @@ public static Elements ofString(final String str) {
public final static IElement PROTACTINIUM = Protactinium.toIElement();
public final static IElement URANIUM = Uranium.toIElement();
public final static IElement NEPTUNIUM = Neptunium.toIElement();
- public final static IElement PLUTOMNIUM = Plutonium.toIElement();
Could you add the following to avoid the API change - not that many people would likely be using this. thanks
@deprecated
PLUTOMNIUM = PLUTONIUM;
—
Reply to this email directly or view it on GitHub.
replaced by #59 |
No description provided.