Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the calls to Session.getNode() in DefaultFilter #86

Closed
wants to merge 1 commit into from

Conversation

fasseg
Copy link
Contributor

@fasseg fasseg commented Jun 19, 2013

The first commit is a simple patch which improves perf slightly, since the large amount of JCR events generated will not cause calls to Session.getNode()

The second commit removes all the calls to Session.getNode() by negating the result of the jcr system and jcr property check.

@ghost ghost assigned ajs6f Jun 25, 2013
@eddies
Copy link

eddies commented Jun 25, 2013

@ajs6f can you please review this?

@ajs6f
Copy link
Contributor

ajs6f commented Jun 25, 2013

Has this been finished? I was waiting for @fasseg to confirm that...

@fasseg
Copy link
Contributor Author

fasseg commented Jun 28, 2013

yeah this is finished, and works for me, the question would just be if that would not bring us into difficulties later since the now the propagation of the event only depends on the contents of the path.

@cbeer
Copy link
Contributor

cbeer commented Jun 28, 2013

JCR 2.1 is going to add

Event.getMixinNodeTypes() returns the declared mixin node types of the node that was added or removed.

I wonder if we should reject this pull request, and instead wait for JCR 2.1 to address this performance issue (rather than accepting this PR and then having to essentially revert it later)?

@fasseg
Copy link
Contributor Author

fasseg commented Jun 29, 2013

This addition in JCR 2.1 sounds really helpful.
But public review of JSR-333 (http://jcp.org/en/jsr/detail?id=333) just closed, so there is no final draft yet and it will take some time until this is implemented by ModeShape.
So I'll gather some numbers on the actual differences on the SCC cluster which I am currently playing around with, in order to get an impression of the perf impact in a clustered environment.

@awoods
Copy link

awoods commented Jul 26, 2013

Any new status on this? If the performance hit is having an impact, then accepting this request now and updating when Mode catches up may make sense.

@cbeer
Copy link
Contributor

cbeer commented Jul 26, 2013

IIRC, this improves performance <%5 (before e.g. the leveldb change, which will make this patch's performance increase that much less.)

@awoods
Copy link

awoods commented Jul 26, 2013

That being the case, I would suggest not merging this and creating a new item to update DefaultFilter when Mode catches up with this aspect of JCR 2.1.

@cbeer cbeer closed this Dec 13, 2013
@cbeer cbeer deleted the perf-defaultfilter branch October 17, 2014 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants