Improve keyword arguments coercion and fix GC crash #3112
Merged
+50
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stil don't grasp the exact reason of GC crash being fixed..
It was reproducible was by this:
RBXOPT='-Xgc.young_autotune_lifetime=0 -Xgc.young_initial_bytes=1000000 -Xgc.young_max_bytes=1000000 -Xgc.show -Xint=1 -Xjit.show -Xjit.call_til_compile=10 -Xjit.call_inline_threshold=10 -Xjit.inline.debug -Xjit.debug' ./bin/mspec --repeat 200 spec/ruby/language/method_spec.rb
Errors were like these:
Maybe, this should also be fixed in vm/block_environment.cpp. But my sleep time has come... ;)