Comparing changes
Open a pull request
base repository: nodejs/node-v0.x-archive
base: 201baa273b11^
head repository: nodejs/node-v0.x-archive
compare: 315afbdc5f0e
- 18 commits
- 22 files changed
- 1 contributor
Commits on May 14, 2013
-
-
stream: don't create unnecessary buffers in Readable
If there is an encoding, and we do 'stream.push(chunk, enc)', and the encoding argument matches the stated encoding, then we're converting from a string, to a buffer, and then back to a string. Of course, this is a completely pointless bit of work, so it's best to avoid it when we know that we can do so safely.
-
stream: Make default encoding configurable
Pretty much everything assumes strings to be utf-8, but crypto traditionally used binary strings, so we need to keep the default that way until most users get off of that pattern.
-
tools: remove unnecessary cpplint rules
We don't actually care about header order much, and since we never use stl classes, 'string' isn't an issue for node ever.
-
src: Add StringBytes static util class
Four functions: - StringBytes::SizeFast() - StringBytes::SizePrecise() - StringBytes::Write() - StringBytes::Encode()
-
-
src: Use StringBytes in StreamWrap revert stream wrap changes (different approach coming)
-
-
src: use StringBytes for DecodeWrite/DecodeBytes/Encode
Bonus: this makes node::Encode actually work properly with base64, ucs2, hex, etc.
-
-
-
-
-
-
-
-
2013.05.14, Version 0.10.6 (Stable)
* module: Deprecate require.extensions (isaacs) * stream: make Readable.wrap support objectMode, empty streams (Daniel Moore) * child_process: fix handle delivery (Ben Noordhuis) * crypto: Fix performance regression (isaacs) * src: DRY string encoding/decoding (isaacs)
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 201baa273b11^...315afbdc5f0e