Remove invalidate from CFGBuilder and resetCFG from IRScope since the…

…se actions are not possible
jruby · Oct 7, 2014 · 736881a · 736881a
1 parent c47d195
commit 736881a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/core/src/main/java/org/jruby/ir/IRScope.java b/core/src/main/java/org/jruby/ir/IRScope.java
@@ -1153,10 +1153,6 @@ public void inlineMethod(IRScope method, RubyModule implClass, int classToken, B
         }
     }
 
-    public void resetCFG() {
-        cfg = null;
-    }
-
     /* Record a begin block -- not all scope implementations can handle them */
     public void recordBeginBlock(IRClosure beginBlockClosure) {
         throw new RuntimeException("BEGIN blocks cannot be added to: " + this.getClass().getName());

diff --git a/core/src/main/java/org/jruby/ir/passes/CFGBuilder.java b/core/src/main/java/org/jruby/ir/passes/CFGBuilder.java
@@ -2,6 +2,15 @@
 
 import org.jruby.ir.IRScope;
 
+/**
+ * CFGBuilder is mainly a pass to be lazy.  We do not want to build CFG for scopes which are never called.
+ *
+ * Once we have a CFG that is the base data structure where we interact with instructions.  The original
+ * list of instructions from IRBuilder is no longer important.  This is also why this pass is incapable
+ * of invalidating the CFG.
+  */
+
+
 public class CFGBuilder extends CompilerPass {
     @Override
     public String getLabel() {
@@ -20,6 +29,6 @@ public Object execute(IRScope scope, Object... data) {
 
     @Override
     public void invalidate(IRScope scope) {
-        scope.resetCFG();
+        // CFG is primal information to a scope and cannot be recreated once generated.
     }
 }