add logging to exception mappers

fcrepo · May 16, 2013 · 30b3bf7 · 30b3bf7
1 parent 8ce2ebb
commit 30b3bf7
Show file tree

Hide file tree

Showing 4 changed files with 48 additions and 0 deletions.
diff --git a/...http-commons/src/main/java/org/fcrepo/exceptionhandlers/AccessControlExceptionMapper.java b/...http-commons/src/main/java/org/fcrepo/exceptionhandlers/AccessControlExceptionMapper.java
@@ -1,8 +1,11 @@
 
 package org.fcrepo.exceptionhandlers;
 
+import org.slf4j.Logger;
+
 import static javax.ws.rs.core.Response.status;
 import static javax.ws.rs.core.Response.Status.FORBIDDEN;
+import static org.slf4j.LoggerFactory.getLogger;
 
 import javax.jcr.security.AccessControlException;
 import javax.ws.rs.core.Response;
@@ -13,8 +16,11 @@
 public class AccessControlExceptionMapper implements
         ExceptionMapper<AccessControlException> {
 
+    private final Logger LOGGER = getLogger(AccessControlExceptionMapper.class);
+
     @Override
     public Response toResponse(final AccessControlException arg0) {
+        LOGGER.warn("Got access control exception: {}", arg0.getMessage());
         return status(FORBIDDEN).build();
     }
 

diff --git a/...-http-commons/src/main/java/org/fcrepo/exceptionhandlers/PathNotFoundExceptionMapper.java b/...-http-commons/src/main/java/org/fcrepo/exceptionhandlers/PathNotFoundExceptionMapper.java
@@ -1,8 +1,11 @@
 
 package org.fcrepo.exceptionhandlers;
 
+import org.slf4j.Logger;
+
 import static javax.ws.rs.core.Response.status;
 import static javax.ws.rs.core.Response.Status.NOT_FOUND;
+import static org.slf4j.LoggerFactory.getLogger;
 
 import javax.jcr.PathNotFoundException;
 import javax.ws.rs.core.Response;
@@ -13,8 +16,12 @@
 public class PathNotFoundExceptionMapper implements
         ExceptionMapper<PathNotFoundException> {
 
+
+    private final Logger LOGGER = getLogger(PathNotFoundExceptionMapper.class);
+
     @Override
     public Response toResponse(final PathNotFoundException arg0) {
+        LOGGER.info("Caught a path-not-found exception: {}", arg0.getMessage());
         return status(NOT_FOUND).build();
     }
 

diff --git a/...po-http-commons/src/main/java/org/fcrepo/exceptionhandlers/RepositoryExceptionMapper.java b/...po-http-commons/src/main/java/org/fcrepo/exceptionhandlers/RepositoryExceptionMapper.java
@@ -0,0 +1,28 @@
+package org.fcrepo.exceptionhandlers;
+
+import org.slf4j.Logger;
+
+import javax.jcr.RepositoryException;
+import javax.ws.rs.core.Response;
+import javax.ws.rs.ext.ExceptionMapper;
+import javax.ws.rs.ext.Provider;
+
+import static com.google.common.base.Throwables.getStackTraceAsString;
+import static javax.ws.rs.core.Response.serverError;
+import static org.slf4j.LoggerFactory.getLogger;
+
+@Provider
+public class RepositoryExceptionMapper implements ExceptionMapper<RepositoryException> {
+
+    private final Logger LOGGER = getLogger(RepositoryExceptionMapper.class);
+
+    Boolean showStackTrace = true;
+
+    @Override
+    public Response toResponse(RepositoryException e) {
+
+        LOGGER.warn("Caught repository exception: {}", e);
+
+        return serverError().entity(showStackTrace ? getStackTraceAsString(e) : null).build();
+    }
+}
diff --git a/fcrepo-http-commons/src/main/java/org/fcrepo/exceptionhandlers/WildcardExceptionMapper.java b/fcrepo-http-commons/src/main/java/org/fcrepo/exceptionhandlers/WildcardExceptionMapper.java
@@ -1,8 +1,11 @@
 
 package org.fcrepo.exceptionhandlers;
 
+import org.slf4j.Logger;
+
 import static com.google.common.base.Throwables.getStackTraceAsString;
 import static javax.ws.rs.core.Response.serverError;
+import static org.slf4j.LoggerFactory.getLogger;
 
 import javax.ws.rs.core.Response;
 import javax.ws.rs.ext.ExceptionMapper;
@@ -11,10 +14,14 @@
 @Provider
 public class WildcardExceptionMapper implements ExceptionMapper<Exception> {
 
+
+    private final Logger LOGGER = getLogger(WildcardExceptionMapper.class);
+
     Boolean showStackTrace = true;
 
     @Override
     public Response toResponse(final Exception e) {
+        LOGGER.error("{}", e);
 
         return serverError().entity(
                 showStackTrace ? getStackTraceAsString(e) : null).build();