Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 51f128d64b25
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 1a65154d7296
Choose a head ref
  • 18 commits
  • 47 files changed
  • 9 contributors

Commits on Mar 21, 2013

  1. timers: handle signed int32 overflow in enroll()

    Before this patch calling `socket.setTimeout(0xffffffff)` will result in
    signed int32 overflow in C++ which resulted in assertion error:
    
        Assertion failed: (timeout >= -1), function uv__io_poll, file
        ../deps/uv/src/unix/kqueue.c, line 121.
    
    see #5101
    indutny committed Mar 21, 2013
    Copy the full SHA
    bfd16de View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2013

  1. stream: Fix stall in Transform under very specific conditions

    The stall is exposed in the test, though the test itself asserts before
    it stalls.
    
    The test is constructed to replicate the stalling state of a complex
    Passthrough usecase since I was not able to reliable trigger the stall.
    
    Some of the preconditions for triggering the stall are:
      * rs.length >= rs.highWaterMark
      * !rs.needReadable
      * _transform() handler that can return empty transforms
      * multiple sync write() calls
    
    Combined this can trigger a case where rs.reading is not cleared when
    further progress requires this. The fix is to always clear rs.reading.
    kanongil authored and isaacs committed Mar 22, 2013
    Copy the full SHA
    c3aae9c View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2013

  1. Copy the full SHA
    132c77e View commit details
    Browse the repository at this point in the history
  2. crypto: check randomBytes() size argument

    Throw a TypeError if size > 0x3fffffff. Avoids the following V8 fatal
    error:
    
      FATAL ERROR: v8::Object::SetIndexedPropertiesToExternalArrayData()
      length exceeds max acceptable value
    
    Fixes #5126.
    bnoordhuis committed Mar 23, 2013
    Copy the full SHA
    628bd81 View commit details
    Browse the repository at this point in the history
  3. v8: Unify kMaxArguments with number of bits used to encode it.

    Increase the number of bits by 1 by making Flags unsigned.
    
    BUG=chromium:211741
    
    Review URL: https://chromiumcodereview.appspot.com/12886008
    
    This is a back-port of commits 13964 and 13988 addressing CVE-2013-2632.
    verwaest authored and bnoordhuis committed Mar 23, 2013
    Copy the full SHA
    14417fd View commit details
    Browse the repository at this point in the history
  4. tls: remove harmful unnecessary bounds checking

    The EncIn, EncOut, ClearIn & ClearOut functions are victims of some code
    copy + pasting. A common line copied to all of them is:
    
    `if (off >= buffer_length) { ...`
    
    448e0f4 corrected ClearIn's check from `>=` to `>`, but left the others
    unchanged (with an incorrect bounds check). However, if you look down at
    the next very next bounds check you'll see:
    
    `if (off + len > buffer_length) { ...`
    
    So the check is actually obviated by the next line, and should be
    removed.
    
    This fixes an issue where writing a zero-length buffer to an encrypted
    pair's *encrypted* stream you would get a crash.
    laverdet authored and indutny committed Mar 23, 2013
    Copy the full SHA
    1526909 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2013

  1. timer: fix off-by-one ms error

    Fix #5103
    AlexeyKupershtokh authored and isaacs committed Mar 24, 2013
    Copy the full SHA
    9fae4dc View commit details
    Browse the repository at this point in the history
  2. doc: update CONTRIBUTING.md

    * Latest stable is v0.10 now.
    * Add example of what the first line of the commit log should look like.
    bnoordhuis committed Mar 24, 2013
    Copy the full SHA
    329b538 View commit details
    Browse the repository at this point in the history
  3. tools: update gyp to r1601

    Among other things, this should make it easier for people to build
    node.js on openbsd.
    bnoordhuis committed Mar 24, 2013
    Copy the full SHA
    8632af3 View commit details
    Browse the repository at this point in the history
  4. stream: Fix early end in Writables on zero-length writes

    Doing this causes problems:
    
        z.write(Buffer(0));
        z.end();
    
    Fix by not ending Writable streams while they're still in the process of
    writing something.
    isaacs committed Mar 24, 2013
    Copy the full SHA
    c0d5001 View commit details
    Browse the repository at this point in the history
  5. deps: fix openssl build on windows

    Commit 8632af3 ("tools: update gyp to r1601") broke the Windows build.
    
    Older versions of GYP link to kernel32.lib, user32.lib, etc. but that
    was changed in r1584. See https://codereview.chromium.org/12256017
    
    Fix the build by explicitly linking to the required libraries.
    bnoordhuis committed Mar 24, 2013
    Copy the full SHA
    690a8cc View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2013

  1. Copy the full SHA
    05bd6b7 View commit details
    Browse the repository at this point in the history
  2. child_process: fix sending utf-8 to child process

    In process#send() and child_process.ChildProcess#send(), use 'utf8' as
    the encoding instead of 'ascii' because 'ascii' mutilates non-ASCII
    input. Correctly handle partial character sequences by introducing
    a StringDecoder.
    
    Sending over UTF-8 no longer works in v0.10 because the high bit of
    each byte is now cleared when converting a Buffer to ASCII. See
    commit 96a314b for details.
    
    Fixes #4999 and #5011.
    bnoordhuis committed Mar 25, 2013
    Copy the full SHA
    44843a6 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    488b74d View commit details
    Browse the repository at this point in the history
  4. crypto: make getCiphers() return non-SSL ciphers

    Commit f53441a added crypto.getCiphers() as a function that returns the
    names of SSL ciphers.
    
    Commit 14a6c4e then added crypto.getHashes(), which returns the names of
    digest algorithms, but that creates a subtle inconsistency: the return
    values of crypto.getHashes() are valid arguments to crypto.createHash()
    but that is not true for crypto.getCiphers() - the returned values are
    only valid for SSL/TLS functions.
    
    Rectify that by adding tls.getCiphers() and making crypto.getCiphers()
    return proper cipher names.
    bnoordhuis committed Mar 25, 2013
    Copy the full SHA
    cfd0dca View commit details
    Browse the repository at this point in the history
  5. child_process: don't emit same handle twice

    It's possible to read multiple messages off the parent/child channel.
    When that happens, make sure that recvHandle is cleared after emitting
    the first message so it doesn't get emitted twice.
    bnoordhuis committed Mar 25, 2013
    Copy the full SHA
    9352c19 View commit details
    Browse the repository at this point in the history
  6. test: test name is the last elem, not second

    When a test requires node to have parameters passed (--expose-gc) the
    test name will be the last element in the command array, not the second.
    tjfontaine authored and bnoordhuis committed Mar 25, 2013
    Copy the full SHA
    fb6dd0c View commit details
    Browse the repository at this point in the history
  7. Merge remote-tracking branch 'origin/v0.10'

    Conflicts:
    	deps/v8/src/objects-inl.h
    	deps/v8/src/objects.h
    	src/node_crypto.cc
    bnoordhuis committed Mar 25, 2013
    Copy the full SHA
    1a65154 View commit details
    Browse the repository at this point in the history