[Truffle] Implemented Binding#dup.

jruby · Feb 9, 2015 · 27255ad · nirvdrum · Feb 10, 2015 · chrisseaton
1 parent 4593de4
commit 27255ad
Showing 5 changed files with 51 additions and 7 deletions.
diff --git a/spec/truffle/tags/core/binding/clone_tags.txt b/spec/truffle/tags/core/binding/clone_tags.txt
diff --git a/spec/truffle/tags/core/binding/dup_tags.txt b/spec/truffle/tags/core/binding/dup_tags.txt
diff --git a/truffle/src/main/java/org/jruby/truffle/nodes/core/BindingNodes.java b/truffle/src/main/java/org/jruby/truffle/nodes/core/BindingNodes.java
@@ -13,16 +13,44 @@
 import com.oracle.truffle.api.frame.FrameSlot;
 import com.oracle.truffle.api.frame.MaterializedFrame;
 import com.oracle.truffle.api.source.SourceSection;
+import org.jruby.runtime.Visibility;
 import org.jruby.truffle.nodes.globals.GetFromThreadLocalNode;
 import org.jruby.truffle.nodes.globals.WrapInThreadLocalNode;
 import org.jruby.truffle.runtime.RubyArguments;
 import org.jruby.truffle.runtime.RubyContext;
 import org.jruby.truffle.runtime.core.RubyBinding;
+import org.jruby.truffle.runtime.core.RubyString;
 import org.jruby.truffle.runtime.core.RubySymbol;
 
 @CoreClass(name = "Binding")
 public abstract class BindingNodes {
 
+    @CoreMethod(names = "initialize_copy", visibility = Visibility.PRIVATE, required = 1)
+    public abstract static class InitializeCopyNode extends CoreMethodNode {
+
+        public InitializeCopyNode(RubyContext context, SourceSection sourceSection) {
+            super(context, sourceSection);
+        }
+
+        public InitializeCopyNode(InitializeCopyNode prev) {
+            super(prev);
+        }
+
+        @Specialization
+        public Object initializeCopy(RubyBinding self, RubyBinding from) {
+            notDesignedForCompilation();
+
+            if (self == from) {
+                return self;
+            }
+
+            self.initialize(from.getSelf(), from.getFrame());
+
+            return self;
+        }
+
+    }
+
     @CoreMethod(names = "local_variable_get", required = 1)
     public abstract static class LocalVariableGetNode extends CoreMethodNode {
 

diff --git a/truffle/src/main/java/org/jruby/truffle/runtime/core/CoreLibrary.java b/truffle/src/main/java/org/jruby/truffle/runtime/core/CoreLibrary.java
@@ -240,7 +240,7 @@ public CoreLibrary(RubyContext context) {
         // Classes defined in Object
 
         arrayClass = defineClass("Array", new RubyArray.ArrayAllocator());
-        bindingClass = defineClass("Binding");
+        bindingClass = defineClass("Binding", new RubyBinding.BindingAllocator());
         dirClass = defineClass("Dir");
         encodingClass = defineClass("Encoding", new RubyEncoding.EncodingAllocator());
         falseClass = defineClass("FalseClass");

diff --git a/truffle/src/main/java/org/jruby/truffle/runtime/core/RubyBinding.java b/truffle/src/main/java/org/jruby/truffle/runtime/core/RubyBinding.java
@@ -9,20 +9,33 @@
  */
 package org.jruby.truffle.runtime.core;
 
+import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.frame.MaterializedFrame;
+import org.jruby.truffle.nodes.RubyNode;
+import org.jruby.truffle.nodes.objects.Allocator;
+import org.jruby.truffle.runtime.RubyContext;
 import org.jruby.truffle.runtime.subsystems.ObjectSpaceManager;
+import org.jruby.util.ByteList;
 
 /**
  * Represents the Ruby {@code Binding} class.
  */
 public class RubyBinding extends RubyBasicObject {
 
-    private final Object self;
-    private final MaterializedFrame frame;
+    @CompilerDirectives.CompilationFinal private Object self;
+    @CompilerDirectives.CompilationFinal private MaterializedFrame frame;
+
+    public RubyBinding(RubyClass bindingClass) {
+        super(bindingClass);
+    }
 
     public RubyBinding(RubyClass bindingClass, Object self, MaterializedFrame frame) {
         super(bindingClass);
 
+        initialize(self, frame);
+    }
+
+    public void initialize(Object self, MaterializedFrame frame) {
         assert self != null;
         assert frame != null;
 
@@ -43,4 +56,11 @@ public void visitObjectGraphChildren(ObjectSpaceManager.ObjectGraphVisitor visit
         getContext().getObjectSpaceManager().visitFrame(frame, visitor);
     }
 
+    public static class BindingAllocator implements Allocator {
+        @Override
+        public RubyBasicObject allocate(RubyContext context, RubyClass rubyClass, RubyNode currentNode) {
+            return new RubyBinding(rubyClass);
+        }
+    }
+
 }