Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mantisbt/mantisbt
base: 8bb88e7
Choose a base ref
...
head repository: mantisbt/mantisbt
compare: 79c04ca
Choose a head ref
  • 3 commits
  • 15 files changed
  • 1 contributor

Commits on Feb 24, 2012

  1. Fix #13937: Filter dropdown values of [any], [none], etc not saved 

    Damien Regad <damien.regad@merckgroup.com> and Roland Becker
<roland@atrol.de> reported an issue whereby filter dropdowns would
always select the meta filter option of [any] by default, even if the
active filter was set to another value.

The cause is incorrect logic within both the check_checked and
check_selected functions dating back to issue #7995 in 2007.
Documentation has been added inline to the code to clarify how these
functions work and the gotcha to do with == vs. === comparisons.
    @davidhicks
    davidhicks committed Feb 24, 2012
    Copy the full SHA
    1f515b3 View commit details
    Browse the repository at this point in the history

  2. Add missing quotation marks around array key in tag_view_page 

    With maximum error handling enabled, this threw a fatal error: undefined
constant.
    @davidhicks
    davidhicks committed Feb 24, 2012
    Copy the full SHA
    b22da39 View commit details
    Browse the repository at this point in the history

  3. Fix #13937: Fix check_selected and check_checked functions 

    These functions were originally designed very loosely with respect to
input data types. This was causing problems in numerous areas where
strings were being compared with integers, etc.

Both functions have been modified such that an error will be generated
when the types are inconsistent. This will force developers to properly
consider the types of variables when coding with MantisBT, ensuring less
likelihood of bugs arising from "1.1"=="1.10", 0=="" comparisons, etc.

Most if not all elements of the UI with drop-down boxes, check boxes,
radio boxes and lists have been thoroughly tested after these changes.
The default state of these UI fields should once again match default
configuration values in config_inc.php, current values of the
field/filter, etc. This greatly improves the usability of the UI.
    @davidhicks
    davidhicks committed Feb 24, 2012
    Copy the full SHA
    79c04ca View commit details
    Browse the repository at this point in the history