Pass an error to onComplete in all cases, even on broken pipes.

projectodd · Feb 6, 2015 · cccf579 · cccf579
1 parent 1158fca
commit cccf579
Showing 1 changed file with 3 additions and 10 deletions.
diff --git a/modules/web/src/main/java/org/projectodd/wunderboss/web/async/OutputStreamHttpChannel.java b/modules/web/src/main/java/org/projectodd/wunderboss/web/async/OutputStreamHttpChannel.java
@@ -137,18 +137,11 @@ protected void doSend(final byte[] data,
                 sendStarted = true;
             }
 
-            try {
-                this.stream.write(data);
-                if (!shouldClose) {
-                    this.stream.flush();
-                }
-            } catch (IOException e) {
-                // TODO: should we only deal with "Broken pipe" IOE's here? rethrow others?
-                this.closer.run();
-            }
-
+            this.stream.write(data);
             if (shouldClose) {
                 this.closer.run();
+            } else {
+                this.stream.flush();
             }
         } catch (Throwable e) {
             this.closer.run();