Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DEBUG function to work not just print a number #30

Merged
merged 4 commits into from Feb 17, 2015

Conversation

mohawk2
Copy link
Contributor

@mohawk2 mohawk2 commented Feb 2, 2015

$ perl -e 'die prototype("CORE::sprintf")'
$@ at -e line 1.

@ingydotnet
Copy link
Owner

The DEBUG_ON && was meant to constant fold out the DEBUG calls.

Can you add those back?

@mohawk2
Copy link
Contributor Author

mohawk2 commented Feb 4, 2015

Done! Please review and hopefully merge.

@ingydotnet
Copy link
Owner

@mohawk2, I reviewed and fixed up this PR a bit. Pushing this back to branch PR/30.

If you run make dist with the DEBUG on:

  • There are a ton of warnings
  • Some huge string is dumped making the DEBUG info way too big.

Please fix up, and I'll merge it in.

Thanks for the work.

@ingydotnet ingydotnet merged commit 4364abe into ingydotnet:master Feb 17, 2015
@mohawk2 mohawk2 deleted the fixdebug branch February 17, 2015 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants