Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple tag files #2552

Closed
wants to merge 2 commits into from
Closed

Multiple tag files #2552

wants to merge 2 commits into from

Conversation

chrisseaton
Copy link
Contributor

This separates the slow and windows tags into separate directories so that when you look in the main tag directory everything you see is something to work on.

@nirvdrum @eregon

@eregon
Copy link
Member

eregon commented Feb 2, 2015

What about just changing windows tags from fails to sth like failsOnWindows or so?
Having multiple locations is probably hard for auto adding tags and other stuff (although I thought to that idea first when adding slow tags as well).
About having an easier overview of what's left to fix, I think something to count the number of tagged examples (like wc -l) would be quite useful (and aggregating per directory), the file size being a bad indication. And in that case, filtering (grep) is not so much more work.

@chrisseaton
Copy link
Contributor Author

The windows tags are already fails(windows). It does indeed not work well with auto tagging - auto tag and untag will use the first path.

The main motivation for this was so that I can simply look at what works and what doesn't. A command to see that doesn't work as immediately.

@eregon
Copy link
Member

eregon commented Feb 2, 2015

But that means examples failing on Windows are also excluded on Unix, isn't it?
I meant to use another "Tag#tag", so maybe just windows instead of fail (slow being the third).

@chrisseaton
Copy link
Contributor Author

I think these are Windows specific tests - they aren't run unless you are on a Windows system.

@nirvdrum
Copy link
Contributor

nirvdrum commented Feb 3, 2015

FYI, I used two tags:

  • (windows) -- Windows-specific spec
  • (windows bug) -- General spec that happens to fail on Windows

@nirvdrum
Copy link
Contributor

nirvdrum commented Feb 3, 2015

And naturally, the "(windows bug)" specs may very well pass on your non-Windows install. Untagging them would end up causing a failure in Windows CI that you probably wouldn't see locally.

@eregon
Copy link
Member

eregon commented Feb 3, 2015

@nirvdrum Thanks, I thought it was sth like that but was not sure.
We could add an additional --excl-tag windowsBug on the Windows CI of course.

@eregon
Copy link
Member

eregon commented Feb 3, 2015

Should we close this issue then?
(Also I wish to have compatible MSpec and intend to propose my change (bug fix) to the canonical MSpec, but this one would be more debatable).

@chrisseaton chrisseaton closed this Feb 3, 2015
@chrisseaton chrisseaton deleted the multiple-tag-files branch February 3, 2015 21:14
@chrisseaton
Copy link
Contributor Author

We decided the changes to MSpec weren't ideal and we'd like to keep all tags in one place.

@headius headius added this to the Invalid or Duplicate milestone May 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants