-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple tag files #2552
Multiple tag files #2552
Conversation
What about just changing windows tags from |
The windows tags are already The main motivation for this was so that I can simply look at what works and what doesn't. A command to see that doesn't work as immediately. |
But that means examples failing on Windows are also excluded on Unix, isn't it? |
I think these are Windows specific tests - they aren't run unless you are on a Windows system. |
FYI, I used two tags:
|
And naturally, the "(windows bug)" specs may very well pass on your non-Windows install. Untagging them would end up causing a failure in Windows CI that you probably wouldn't see locally. |
@nirvdrum Thanks, I thought it was sth like that but was not sure. |
Should we close this issue then? |
We decided the changes to MSpec weren't ideal and we'd like to keep all tags in one place. |
This separates the
slow
andwindows
tags into separate directories so that when you look in the main tag directory everything you see is something to work on.@nirvdrum @eregon