fixed bug where Mojo::DOM::HTML could not handle tags with lots of at…

…tributes
mojolicious · May 31, 2014 · a0dac22 · a0dac22
1 parent 3f63548
commit a0dac22
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/Changes b/Changes
@@ -1,5 +1,7 @@
 
 5.02  2014-05-31
+  - Fixed bug where Mojo::DOM::HTML could not handle tags with lots of
+    attributes.
 
 5.01  2014-05-30
   - Fixed continuation line handling in Mojo::Headers.

diff --git a/lib/Mojo/DOM/HTML.pm b/lib/Mojo/DOM/HTML.pm
@@ -42,7 +42,7 @@ my $TOKEN_RE = qr/
       \s*
       [^<>\s]+                                      # Tag
       \s*
-      (?:$ATTR_RE)*                                 # Attributes
+      (?:(?:$ATTR_RE){0,32766})*                    # Attributes
     )>
   |
     (<)                                             # Runaway "<"

diff --git a/t/mojo/dom.t b/t/mojo/dom.t
@@ -2358,4 +2358,9 @@ is $dom->tree->[3][1], ' bad idea -- HTML5 ', 'right comment';
 is $dom->tree->[5][1], ' HTML4 ',             'right comment';
 is $dom->tree->[7][1], ' bad idea -- HTML4 ', 'right comment';
 
+# Huge number of attributes
+my $huge = '<div ' . ('a=b ' x 32768) . '>Test</div>';
+$dom = Mojo::DOM->new($huge);
+is $dom->at('div[a=b]')->text, 'Test', 'right text';
+
 done_testing();