Exit iterator when RubyHash#any? short-circuits
#2568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if `any?` returned true early (or threw an exception) the hash would be marked as still iterating, and thus prevent updates.
enebo
added a commit
that referenced
this pull request
Feb 5, 2015
Exit iterator when `RubyHash#any?` short-circuits
|
@grddev Could this be an issue for our 1.7 branch as well? for 1.8.7 or 1.9.3 support? |
|
As far as I can see the |
|
@grddev Great thanks for checking! I also looked and I think this was added specifically to Hash and used to just fall back to Enumerable impl. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if
any?returned true early (or threw an exception) the hash would be marked as still iterating, and thus prevent updates.Expressed in Ruby code, the following results in "can't add a new key into hash during iteration" errors:
I would have liked to put them into tests, but wasn't completely sure were would be most appropriate.