Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Fiber from ext to core #2548

Closed
chrisseaton opened this issue Feb 2, 2015 · 4 comments
Closed

Move Fiber from ext to core #2548

chrisseaton opened this issue Feb 2, 2015 · 4 comments
Labels
core JRuby 9000 ruby 2.0-2.2
Milestone
Invalid or Duplicate

Comments

@chrisseaton
Copy link
Contributor

Fiber used to be an extension module that needed to be explicitly required, but now it's always included. Perhaps it should be moved from ext into the top level? Are there other modules which used to be extensions but are now are core and should be moved, now that we're focusing on 2.x?
@kares
Copy link
Member

kares commented Feb 2, 2015

thread.rb and related (Mutex Queue) also monitor.rb are pre-loaded on MRI 2.x, yet they are not "officially" part of Ruby's core classes. it might be related to require 'rubygems' out-of-the-box ...

in the past (between 1.6 and 1.7) RubyBigDecimal.class was moved into the ext package, which kind of give a hard time to (the minority of) developers such as myself in supporting gems with native extensions (e.g. AR-JDBC) ... just so I can finally say it out loud :)

@chrisseaton
Copy link
Contributor Author

I'm not sure what you're saying then - are you saying don't do it as it's not actually correct, or do it because it's better than they're part of the public API?

@kares
Copy link
Member

kares commented Feb 2, 2015

it seems not correct but if it is to be done please consider doing it in a "Java-compatible" way - keeping a deprecated class on the original place that gets extended on the new one ...

@kares
Copy link
Member

kares commented Jun 11, 2018

in MRI 2.5 require 'fiber' gets a true indicating that it isn't always loaded these days. same in JRuby 9.x

@kares kares closed this as completed Jun 11, 2018
@kares kares added this to the Invalid or Duplicate milestone Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core JRuby 9000 ruby 2.0-2.2
Projects
None yet
Milestone
Invalid or Duplicate
Development

No branches or pull requests
2 participants
@kares @chrisseaton