Introducing relative times: feature request #219 #358
Conversation
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
I'd vote for this ... also do we want to change timeformat() to standardTime() or serverTime() ... something more descriptive and in line with the proposed relativeTime() ? |
|
standardTime() is fine for me.. Otherwise I could simply rename the new function to relativetimeformat() ?Personally I prefer camelCase names regarding readability, nonetheless I'm fine with whatever the majority likes.. |
| return $past_time; | ||
| } | ||
|
|
||
| $past_time = time()- $timestamp; |
There was a problem hiding this comment.
Missing space after right parenthesis.
|
Nice to see this , thanks TE! User interface-only sounds good to me. |
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
Bug was: Fatal error: Declaration of Control_Verification_Captcha::showVerification() must be compatible with that of Control_Verifications::showVerification() Signed-off-by:Thorsten Eurich <thorsten@eurich.de>
|
Here we go, Renamed the timeformat function to standardTime and introduced the relativeTime() in parts of the user interface. |
|
Thank you! :) Lets see it at work. |
Introducing relative times: feature request #219
This PR is up for discussion, please wait before merging..
Question is: Where do we want relative times? I'd personally go with the frontend only and use the standard time format inside all logs / admin area.
Next question: Do we need relative times for future events (e.g. poll expire date, calendar events)? I'd favour real dates
Usage would be: relativeTime() instead of timeformat();