Fix invalid access denied error caused by access_has_bug_level()

dregad · dregad · commit f583a4582f23 · 2013-03-05T10:38:53.000+01:00
Commit d42e80c changed the code in access_has_bug_level() function, and introduced a bug in the call to access_compare_level() when access is limited to issue reporter (inverted parameters caused an incorrect access denied error). See also 9ec47a0. Issue #15538
diff --git a/core/access_api.php b/core/access_api.php
@@ -427,15 +427,15 @@ function access_has_bug_level( $p_access_level, $p_bug_id, $p_user_id = null ) {
 		if( !isset( $s_thresholds[$t_project_id] ) ) {
 			$t_report_bug_threshold = config_get( 'report_bug_threshold', null, $p_user_id, $t_project_id );
 			if( !is_array( $t_report_bug_threshold ) ) {
-				$s_thresholds[$t_project_id] = $t_report_bug_threshold;
+				$s_thresholds[$t_project_id] = $t_report_bug_threshold + 1;
 			} else if ( empty( $t_report_bug_threshold ) ) {
 				$s_thresholds[$t_project_id] = NOBODY;
 			} else {
 				sort( $t_report_bug_threshold );
-				$s_thresholds[$t_project_id] = $t_report_bug_threshold[0];
+				$s_thresholds[$t_project_id] = $t_report_bug_threshold[0] + 1;
 			}
 		}
-		if( !access_compare_level( $s_thresholds[$t_project_id], $t_access_level ) ) {
+		if( !access_compare_level( $t_access_level, $s_thresholds[$t_project_id] ) ) {
 			return false;
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -427,15 +427,15 @@ function access_has_bug_level( $p_access_level, $p_bug_id, $p_user_id = null ) {`
`427`	`427`	`if( !isset( $s_thresholds[$t_project_id] ) ) {`
`428`	`428`	`$t_report_bug_threshold = config_get( 'report_bug_threshold', null, $p_user_id, $t_project_id );`
`429`	`429`	`if( !is_array( $t_report_bug_threshold ) ) {`
`430`		`- $s_thresholds[$t_project_id] = $t_report_bug_threshold;`
	`430`	`+ $s_thresholds[$t_project_id] = $t_report_bug_threshold + 1;`
`431`	`431`	`} else if ( empty( $t_report_bug_threshold ) ) {`
`432`	`432`	`$s_thresholds[$t_project_id] = NOBODY;`
`433`	`433`	`} else {`
`434`	`434`	`sort( $t_report_bug_threshold );`
`435`		`- $s_thresholds[$t_project_id] = $t_report_bug_threshold[0];`
	`435`	`+ $s_thresholds[$t_project_id] = $t_report_bug_threshold[0] + 1;`
`436`	`436`	`}`
`437`	`437`	`}`
`438`		`- if( !access_compare_level( $s_thresholds[$t_project_id], $t_access_level ) ) {`
	`438`	`+ if( !access_compare_level( $t_access_level, $s_thresholds[$t_project_id] ) ) {`
`439`	`439`	`return false;`
`440`	`440`	`}`
`441`	`441`	`}`