Skip to content
This repository has been archived by the owner on Jul 11, 2020. It is now read-only.

Fix public db backups #10

Merged
merged 2 commits into from
Feb 9, 2015

Conversation

mveytsman
Copy link
Contributor

A missing comma in the 'only_tables' directive caused the Backup DSL to interpret the table name as 'versionsdependencies', so the pgdump command was
/usr/local/bin/pg_dump --host='localhost' --port='5432' --table='rubygems' --table='versionsdependencies' --table='linksets' --table='requirements' --table='version_histories' gemcutter_test" and the versions and dependencies table wasn't being backed up.

I also removed the requirements table from the public dump as it is no longer a table in the rubygems.org schema, and any data there would be leftover before the migration and out of date anyway.

The missing comma caused the Backup DSL to interpret the table name as 'versionsdependencies', so the pgdump command was 
`/usr/local/bin/pg_dump  --host='localhost' --port='5432'  --table='rubygems' --table='versionsdependencies' --table='linksets' --table='requirements' --table='version_histories'  gemcutter_test"` and the versions and dependencies table wasn't being backed up
The requirements table is no longer used by rubygems.org (see https://github.com/rubygems/rubygems.org/blob/master/db/migrate/20090820185410_drop_requirements_table.rb)

Any data in it is a vestige of the old schema and shouldn't be included in the public db dump.
@dwradcliffe
Copy link
Member

Oh, snap. Good catch!

dwradcliffe added a commit that referenced this pull request Feb 9, 2015
@dwradcliffe dwradcliffe merged commit f469c43 into rubygems:master Feb 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants