Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix __init__.py in pdq2 and lda #10

Closed
wants to merge 16 commits into from
Closed

fix __init__.py in pdq2 and lda #10

wants to merge 16 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 4, 2015

No description provided.

@sbourdeauducq
Copy link
Member

Experiments never use the lda driver directly (instead they use a controller entry in the DDB) so exporting the driver at the top level does not improve the public API.

I'm planning to export in devices/*/__init__.py only those parts of drivers that need to be executed locally and used directly by the experiment; for example, the high-level PDQ or PXI DAC card APIs that need to define kernels that generate timing pulses.

@jordens
Copy link
Member

jordens commented Feb 7, 2015

Apart from the fact that the stack of commits is messed up:

  • pdq2: Putting actual code (not just namespace mangling) into __init__.py is irritating because then you never know in which file to look for a class, especially if there are other files next to __init__.py. If there are no other modules in the same directoty, rename module/__init__.py to module.py and delete the directory.
  • Cleaning up and flattening the API is a good idea whether public or not.

@ghost ghost deleted the for-upstream branch February 9, 2015 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants