Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 8d2753c14120
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 335f20896aaf
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Nov 23, 2012

  1. crypto: allow negative numbers in setOptions()

    OR'ing together two large values, like `SSL_OP_ALL | SSL_OP_NO_TICKET`,
    produces a negative number. To wit:
    
      assert((0x80000000 | 0x4000) === -0x7fffc000); // true
      assert((0x80000000 | 0x4000) ===  0x80004000); // false!
    
    It's easy to work around by doing a logical shift, like this:
    
      assert((0x80000000 | 0x4000) >>> 0 ===  0x80004000); // true
    
    But that's not very intuitive. Let's be more lenient in what we accept.
    bnoordhuis committed Nov 23, 2012
    Copy the full SHA
    335f208 View commit details
    Browse the repository at this point in the history