Throw exception instead of assert on nested reliable packets

kahrl · kahrl · commit a013f762c4c9 · 2013-07-04T06:18:50.000+02:00
Fixes a denial of service vulnerability, issue #784
diff --git a/src/connection.cpp b/src/connection.cpp
@@ -1436,7 +1436,8 @@ SharedBuffer<u8> Connection::processPacket(Channel *channel,
 	else if(type == TYPE_RELIABLE)
 	{
 		// Recursive reliable packets not allowed
-		assert(reliable == false);
+		if(reliable)
+			throw InvalidIncomingDataException("Found nested reliable packets");
 
 		if(packetdata.getSize() < RELIABLE_HEADER_SIZE)
 			throw InvalidIncomingDataException

Original file line number	Diff line number	Diff line change
`@@ -1436,7 +1436,8 @@ SharedBuffer<u8> Connection::processPacket(Channel *channel,`
`1436`	`1436`	`else if(type == TYPE_RELIABLE)`
`1437`	`1437`	`{`
`1438`	`1438`	`// Recursive reliable packets not allowed`
`1439`		`- assert(reliable == false);`
	`1439`	`+ if(reliable)`
	`1440`	`+ throw InvalidIncomingDataException("Found nested reliable packets");`
`1440`	`1441`
`1441`	`1442`	`if(packetdata.getSize() < RELIABLE_HEADER_SIZE)`
`1442`	`1443`	`throw InvalidIncomingDataException`