Throw exception instead of assert on nested reliable packets

Fixes a denial of service vulnerability, issue #784
minetest · Jul 4, 2013 · a013f76 · a013f76
1 parent 3f6f327
commit a013f76
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/connection.cpp b/src/connection.cpp
@@ -1436,7 +1436,8 @@ SharedBuffer<u8> Connection::processPacket(Channel *channel,
 	else if(type == TYPE_RELIABLE)
 	{
 		// Recursive reliable packets not allowed
-		assert(reliable == false);
+		if(reliable)
+			throw InvalidIncomingDataException("Found nested reliable packets");
 
 		if(packetdata.getSize() < RELIABLE_HEADER_SIZE)
 			throw InvalidIncomingDataException