Fix regression in filter_api.php

dregad · dregad · commit cb4e22cb5c44 · 2013-04-11T16:20:04.000+02:00
Commit c9bc064 introduced a regression, whereby the filter would exclude issues without bugnotes when using text search. This was caused by removal of left outer join between bugnote_table and bugnote_text_table, which was in fact required because the join clause fails to return any record when the bugnote_text_id is null (which is the case when there are no bugnotes). Thanks to user Kitzberger for reporting this and atrol for providing the steps to reproduce.
diff --git a/core/filter_api.php b/core/filter_api.php
@@ -2001,7 +2001,8 @@ function filter_get_bug_rows( &$p_page_number, &$p_per_page, &$p_page_count, &$p
 		if ( !$t_first ) {
 			$t_join_clauses[] = "JOIN $t_bug_text_table ON $t_bug_table.bug_text_id = $t_bug_text_table.id";
 			$t_join_clauses[] = "LEFT JOIN $t_bugnote_table ON $t_bug_table.id = $t_bugnote_table.bug_id";
-			$t_join_clauses[] = "JOIN $t_bugnote_text_table ON $t_bugnote_table.bugnote_text_id = $t_bugnote_text_table.id";
+			# Outer join required otherwise we don't retrieve issues without notes
+			$t_join_clauses[] = "LEFT JOIN $t_bugnote_text_table ON $t_bugnote_table.bugnote_text_id = $t_bugnote_text_table.id";
 			$t_where_clauses[] = $t_textsearch_where_clause;
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -2001,7 +2001,8 @@ function filter_get_bug_rows( &$p_page_number, &$p_per_page, &$p_page_count, &$p`
`2001`	`2001`	`if ( !$t_first ) {`
`2002`	`2002`	`$t_join_clauses[] = "JOIN $t_bug_text_table ON $t_bug_table.bug_text_id = $t_bug_text_table.id";`
`2003`	`2003`	`$t_join_clauses[] = "LEFT JOIN $t_bugnote_table ON $t_bug_table.id = $t_bugnote_table.bug_id";`
`2004`		`- $t_join_clauses[] = "JOIN $t_bugnote_text_table ON $t_bugnote_table.bugnote_text_id = $t_bugnote_text_table.id";`
	`2004`	`+ # Outer join required otherwise we don't retrieve issues without notes`
	`2005`	`+ $t_join_clauses[] = "LEFT JOIN $t_bugnote_text_table ON $t_bugnote_table.bugnote_text_id = $t_bugnote_text_table.id";`
`2005`	`2006`	`$t_where_clauses[] = $t_textsearch_where_clause;`
`2006`	`2007`	`}`
`2007`	`2008`	`}`