Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: aa3b4b4d1064
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 28eee0adb788
Choose a head ref
  • 3 commits
  • 62 files changed
  • 3 contributors

Commits on Aug 7, 2014

  1. deps: update libuv to v0.11.28

    @indutny
    indutny committed Aug 7, 2014
    Copy the full SHA
    e49429e View commit details
    Browse the repository at this point in the history

  2. Cluster: fix shared handles on Windows 

    This is the Node side of the fix for Node's cluster module on Windows.
#7691

The other required part is
joyent/libuv#1384

Windows and Unix return certain socket errors (i.e. EADDRINUSE) at
different times: bind on Windows, and listen on Unix.
In an effort to hide this difference, libuv on Windows stores such
errors in the bind_error field of uv_tcp_t, to defer raising it at
listen time.
This worked fine except for the case in which a socket is shared in
a Node cluster and a bind error occurs.

A previous attempt to fix this (
joyent/libuv@d1e6be1
3da36fe
) was flawed becaused in an attempt to relay the error at the JS level
it caused the master to start accepting connections.

With this new approach, libuv itself is relaying the bind errors,
providing for a uniform behavior of uv_tcp_listen.

Reviewed-By: Fedor Indutny <fedor@indutny.com>
    @orangemocha @indutny
    orangemocha authored and indutny committed Aug 7, 2014
    Copy the full SHA
    7ca4fa5 View commit details
    Browse the repository at this point in the history

  3. src: handle UV_EAGAIN in TryWrite 

    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    @saghul @indutny
    saghul authored and indutny committed Aug 7, 2014
    Copy the full SHA
    28eee0a View commit details
    Browse the repository at this point in the history