Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5a57d64b7b33
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7e8bda7a37ef
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Feb 9, 2015

  1. [Truffle] I don't think we need a defined? check on ||=

    @chrisseaton
    chrisseaton committed Feb 9, 2015
    Copy the full SHA
    7e8bda7 View commit details
Showing with 3 additions and 1 deletion.
  1. +3 −1 truffle/src/main/java/org/jruby/truffle/translator/BodyTranslator.java
4 changes: 3 additions & 1 deletion truffle/src/main/java/org/jruby/truffle/translator/BodyTranslator.java
View file
Original file line number Diff line number Diff line change
@@ -2153,7 +2153,9 @@ public RubyNode visitOpAsgnOrNode(org.jruby.ast.OpAsgnOrNode node) {
RubyNode lhs = node.getFirstNode().accept(this);
RubyNode rhs = node.getSecondNode().accept(this);

if (node.getFirstNode().needsDefinitionCheck()) {
// I think this is only required for constants - not instance variables

if (node.getFirstNode().needsDefinitionCheck() && !(node.getFirstNode() instanceof org.jruby.ast.InstVarNode)) {
RubyNode defined = new DefinedNode(context, lhs.getSourceSection(), lhs);
lhs = new AndNode(context, lhs.getSourceSection(), defined, lhs);
}