Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Truffle] Tag some Windows failing specs.
- Loading branch information
1 parent
800371d
commit 5a57d64
Showing
4 changed files
with
24 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| fails(windows bug):Encoding.default_internal with command line options returns Encoding::UTF_8 if ruby was invoked with -U | ||
| fails(windows bug):Encoding.default_internal with command line options uses the encoding specified when ruby is invoked with an '-E :internal' argument | ||
| fails(windows bug):Encoding.default_internal with command line options uses the encoding specified when ruby is invoked with an '-E external:internal' argument |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,3 @@ | ||
| fails:File.readable? accepts an object that has a #to_path method | ||
| fails(windows bug):File.readable? returns true if named file is readable by the effective user id of the process, otherwise false | ||
| fails(windows bug):File.readable? returns false if the file does not exist |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,18 @@ | ||
| fails:Signal.trap the special EXIT signal code accepts the EXIT code | ||
| fails:Signal.trap the special EXIT signal code runs the proc before at_exit handlers | ||
| fails(windows bug):Signal.trap returns the previous handler | ||
| fails(windows bug):Signal.trap accepts a block in place of a proc/command argument | ||
| fails(windows bug):Signal.trap ignores the signal when passed nil | ||
| fails(windows bug):Signal.trap accepts 'DEFAULT' as a symbol in place of a proc | ||
| fails(windows bug):Signal.trap accepts 'SIG_DFL' as a symbol in place of a proc | ||
| fails(windows bug):Signal.trap accepts 'SIG_IGN' as a symbol in place of a proc | ||
| fails(windows bug):Signal.trap accepts 'IGNORE' as a symbol in place of a proc | ||
| fails(windows bug):Signal.trap accepts long names as Strings | ||
| fails(windows bug):Signal.trap acceps short names as Strings | ||
| fails(windows bug):Signal.trap accepts long names as Symbols | ||
| fails(windows bug):Signal.trap accepts short names as Symbols | ||
| fails(windows bug):Signal.trap accepts 'SIG_DFL' in place of a proc | ||
| fails(windows bug):Signal.trap accepts 'DEFAULT' in place of a proc | ||
| fails(windows bug):Signal.trap accepts 'SIG_IGN' in place of a proc | ||
| fails(windows bug):Signal.trap accepts 'IGNORE' in place of a proc | ||
| fails(windows bug):Signal.trap the special EXIT signal code can unset the handler |
5a57d64There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really dislike this, it's basically opening the door for regressions (and in this case I even think there was one). I am for a "windows" tag instead of
fails. It is also very confusing when I try to test my fixes (need to untag + discard).5a57d64There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, not sure what it is you dislike? They failed on Windows, so I tagged them as failing - what could we do better?
5a57d64There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this was
failsOnWindows:....then it would not be excluded on other platforms and it would avoid regressions on these specs. Of course, as @nirvdrum said, this could lead to paying less attention to windows issues, but I think it's easy enough to regularly grep for them, and also they show up in the common tag file so they are not ignored, just more precise fail tags.5a57d64There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 978bc56