Fixes #14217: PHP error when attempting to save a filter

vboctor · vboctor · commit a7668f70ee62 · 2012-05-06T13:52:17.000-07:00
1. Fixed the error that used to occur when rendering the save filter form.
2. Add an id to the form div.
3. Centered the save filter form using CSS.
diff --git a/core/filter_api.php b/core/filter_api.php
@@ -3369,7 +3369,6 @@ function filter_draw_selection_area2( $p_page_number, $p_for_screen = true, $p_e
 	<div class="submit-query"><input type="submit" name="filter" value="<?php echo lang_get( 'filter_button' )?>" /></div>
 	</form>
 	<?php
-	$t_stored_queries_arr = array();
 	$t_stored_queries_arr = filter_db_get_available_queries();
 
 	if( access_has_project_level( config_get( 'stored_query_create_threshold' ) ) ) { ?>
diff --git a/css/default.css b/css/default.css
@@ -312,6 +312,7 @@ select.tainted { background-color: #ffffff; color: red; }
 .filter-box { margin: 0; padding: 0; font-size: .9em; }
 .filter-box table { margin: 0; padding: 0; }
 .filter-links { padding: .5em; }
+div#save-filter { text-align: center; }
 .stored-queries select { font-size: .9em; }
 #error-msg { clear: both; }
 .error-msg { color: red; text-align: center; }
diff --git a/query_store_page.php b/query_store_page.php
@@ -57,7 +57,7 @@
 html_page_top();
 ?>
 <br />
-<div>
+<div id="save-filter">
 <?php
 $t_query_to_store = filter_db_get_filter( gpc_get_cookie( config_get( 'view_all_cookie' ), '' ) );
 $t_query_arr = filter_db_get_available_queries();
@@ -88,7 +88,7 @@
 	print '<br />';
 }
 ?>
-<input type="checkbox" name="all_projects" value="on" <?php check_checked( ALL_PROJECTS == helper_get_current_project() ) ?> >
+<input type="checkbox" name="all_projects" value="on" <?php check_checked( ALL_PROJECTS == helper_get_current_project() ) ?> />
 <?php print lang_get( 'all_projects' ); ?><br /><br />
 <input type="submit" class="button" value="<?php print lang_get( 'save_query' ); ?>" />
 </form>
