Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of callback-style handles missing from release notes #783

Closed
PragTob opened this issue Jun 2, 2013 · 3 comments
Closed

Deprecation of callback-style handles missing from release notes #783

PragTob opened this issue Jun 2, 2013 · 3 comments

Comments

@PragTob
Copy link

PragTob commented Jun 2, 2013

Hi everyone,

thank you for working on JRuby :-)

Just something that made figuring out an error for me a bit hard: The deprecation of callback-style handles as of ed0a495 is not mentioned in the release notes for jruby-1.7.4.

I think it should be added as it is an important information and I also saw someone on IRC ask about it before I knew what it was :-)

Cheers and thanks,
Tobi

@headius
Copy link
Member

headius commented Jun 2, 2013

They were actually deprecated a long time ago and just removed recently.
The additional deprecations should have been in place and usually the
others would have been seen, but unfortunately some code may not have seen
deprecation warnings.

What issue did you have?

  • Charlie

On Mon, Jun 3, 2013 at 8:15 AM, Tobias Pfeiffer notifications@github.comwrote:

Hi everyone,

thank you for working on JRuby :-)

Just something that made figuring out an error for me a bit hard: The
deprecation of callback-style handles as of ed0a495ed0a495c6is not mentioned in the release
notes http://jruby.org/2013/05/16/jruby-1-7-4.html for jruby-1.7.4.

I think it should be added as it is an important information and I also
saw someone on IRC ask about it before I knew what it was :-)

Cheers and thanks,
Tobi


Reply to this email directly or view it on GitHubhttps://github.com//issues/783
.

@PragTob
Copy link
Author

PragTob commented Jun 3, 2013

Hi Charles,

no big issues, it's just that Hacketyhack still uses hpricot (yeah I know) and hpricot-java does not work with jruby-1.7.4 (well it is unmaintained so no surprise). I already opened an issue on Hacketyhack. So we should move to nokogiri no biggie.

As googling the error message brought me straight to the source code I thought having it in the release notes might be better :-)

Cheers and thanks for the quick feedback,
Tobi

@PragTob
Copy link
Author

PragTob commented Feb 8, 2015

I think this is outdated now --> close

@PragTob PragTob closed this as completed Feb 8, 2015
@enebo enebo added this to the Invalid or Duplicate milestone Apr 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants