Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RubyArray#flatten! uses respond_to? unlike the original [lotus] #2563

Closed
PragTob opened this issue Feb 4, 2015 · 5 comments
Closed

RubyArray#flatten! uses respond_to? unlike the original [lotus] #2563

PragTob opened this issue Feb 4, 2015 · 5 comments
Labels
core JRuby 9000
Milestone
JRuby 9.0.0.0.rc1

Comments

@PragTob
Copy link

PragTob commented Feb 4, 2015

Noticed while running through lotus/controller for JRuby compatibility.

On a fairly recent master master (updated an hour ago or so) the following behaviour is observable:

jruby-head:

jruby-head :003 > [BasicObject.new].flatten!
NoMethodError: undefined method `respond_to?' for #<BasicObject:0x7c24d3f1>
    from org/jruby/RubyArray.java:2841:in `flatten!'
    from (irb):3:in `evaluate'
    from org/jruby/RubyKernel.java:1000:in `eval'
    from org/jruby/RubyKernel.java:1310:in `loop'
    from org/jruby/RubyKernel.java:1120:in `catch'
    from org/jruby/RubyKernel.java:1120:in `catch'
    from /home/tobi/.rvm/rubies/jruby-head/bin/irb:13:in `__script__'

vs. 2.2.0:

2.2.0 :006 > [BasicObject.new].flatten!
 => nil

This makes a spec in lotus/controller fail.

This seems reasonably easy to fix - time is scarce as always but I'd love to give this a shot this weekend (will hopefully get to it) - but I gotta setup the whole JRuby project first, we'll see :) However, anyone - don't let that stop you! :)

On a larger scale, though - it seems like almost nothing should use respond_to? as a BasicObject might not have that.

Cheers,
Tobi
@PragTob PragTob mentioned this issue Feb 5, 2015
Merged
@lucasallan
Copy link
Member

Hi @PragTob
Any progress on this?

@PragTob
Copy link
Author

PragTob commented Mar 25, 2015

Hey @lucasallan - no unfortunately not, no time. I'd still love to get my hands on this but no guarantees and even if I really pushed it would happen at the easter weekend at the earlies.

@lucasallan
Copy link
Member

@PragTob no worries, let us know if you need any help.

@headius
Copy link
Member

headius commented May 22, 2015

I'm sure this is just blindly dispatching to respond_to? rather than checking if it exists first. Will compare with MRI.

@deepj
Copy link

deepj commented May 22, 2015

The problem lies in Lotus::Kernel.Array.
https://github.com/lotus/controller/blob/master/lib/lotus/controller/configuration.rb#L393

@headius you can isolate it via this test:

git clone git@github.com:lotus/controller.git
cd controller
bundle
ruby -Itest test/configuration_test.rb --name 'test_0003_raises an error if the given mime type cannot be coerced into string'

headius added a commit that referenced this issue May 22, 2015
@headius
Add spec for Array#flatten coersion protocols.
7a40580 
See #2563.
headius added a commit that referenced this issue May 22, 2015
@headius
Make BasicObject "check" methods use proper protocol. #2563
e266e64
@headius headius added this to the JRuby 9.0.0.0.rc1 milestone May 22, 2015
headius added a commit to ruby/spec that referenced this issue Jun 2, 2015
@headius @eregon
Add spec for Array#flatten coersion protocols.
0c28bab 
See jruby/jruby#2563.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core JRuby 9000
Projects
None yet
Milestone
JRuby 9.0.0.0.rc1
Development

No branches or pull requests
4 participants
@headius @deepj @lucasallan @PragTob