-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RubyArray#flatten! uses respond_to?
unlike the original [lotus]
#2563
Comments
Hi @PragTob |
Hey @lucasallan - no unfortunately not, no time. I'd still love to get my hands on this but no guarantees and even if I really pushed it would happen at the easter weekend at the earlies. |
@PragTob no worries, let us know if you need any help. |
I'm sure this is just blindly dispatching to respond_to? rather than checking if it exists first. Will compare with MRI. |
The problem lies in Lotus::Kernel.Array. @headius you can isolate it via this test:
|
Noticed while running through
lotus/controller
for JRuby compatibility.On a fairly recent master master (updated an hour ago or so) the following behaviour is observable:
jruby-head:
vs. 2.2.0:
This makes a spec in lotus/controller fail.
This seems reasonably easy to fix - time is scarce as always but I'd love to give this a shot this weekend (will hopefully get to it) - but I gotta setup the whole JRuby project first, we'll see :) However, anyone - don't let that stop you! :)
On a larger scale, though - it seems like almost nothing should use
respond_to?
as aBasicObject
might not have that.Cheers,
Tobi
The text was updated successfully, but these errors were encountered: