use transliteration when possible

mojolicious · Feb 23, 2014 · 84db5a7 · 84db5a7
1 parent 097650c
commit 84db5a7
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/Changes b/Changes
@@ -1,5 +1,5 @@
 
-4.85  2014-02-23
+4.85  2014-02-24
 
 4.84  2014-02-22
   - Added remaining attribute to Mojo::IOLoop::Delay.

diff --git a/lib/Mojo/Headers.pm b/lib/Mojo/Headers.pm
@@ -18,7 +18,7 @@ my %NORMALCASE = map { lc($_) => $_ } (
 );
 for my $header (values %NORMALCASE) {
   my $name = lc $header;
-  $name =~ s/-/_/g;
+  $name =~ y/-/_/;
   monkey_patch __PACKAGE__, $name, sub { scalar shift->header($header => @_) };
 }
 

diff --git a/lib/Mojo/Message/Request.pm b/lib/Mojo/Message/Request.pm
@@ -204,7 +204,7 @@ sub _parse_env {
   my $base    = $url->base;
   while (my ($name, $value) = each %$env) {
     next unless $name =~ s/^HTTP_//i;
-    $name =~ s/_/-/g;
+    $name =~ y/_/-/;
     $headers->header($name => $value);
 
     # Host/Port

diff --git a/lib/Mojo/Template.pm b/lib/Mojo/Template.pm
@@ -94,7 +94,7 @@ sub compile {
   # Compile with line directive
   return undef unless my $code = $self->code;
   my $name = $self->name;
-  $name =~ s/"//g;
+  $name =~ y/"//d;
   my $compiled = eval qq{#line 1 "$name"\n$code};
   $self->compiled($compiled) and return undef unless $@;
 

diff --git a/lib/Mojolicious/Plugin/TagHelpers.pm b/lib/Mojolicious/Plugin/TagHelpers.pm
@@ -214,7 +214,7 @@ sub _tag {
   my %attrs = @_;
   if ($attrs{data} && ref $attrs{data} eq 'HASH') {
     while (my ($key, $value) = each %{$attrs{data}}) {
-      $key =~ tr/_/-/;
+      $key =~ y/_/-/;
       $attrs{lc("data-$key")} = $value;
     }
     delete $attrs{data};

diff --git a/lib/Mojolicious/Sessions.pm b/lib/Mojolicious/Sessions.pm
@@ -13,7 +13,7 @@ sub load {
   my ($self, $c) = @_;
 
   return unless my $value = $c->signed_cookie($self->cookie_name);
-  $value =~ s/-/=/g;
+  $value =~ y/-/=/;
   return unless my $session = j(b64_decode $value);
 
   # "expiration" value is inherited
@@ -47,7 +47,7 @@ sub store {
     if $expiration || $default;
 
   my $value = b64_encode(encode_json($session), '');
-  $value =~ s/=/-/g;
+  $value =~ y/=/-/;
   my $options = {
     domain   => $self->cookie_domain,
     expires  => $session->{expires},