Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 1425ccd1b2ba
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: fd2cb7c61159
Choose a head ref
  • 1 commit
  • 4 files changed
  • 1 contributor

Commits on Dec 22, 2014

  1. timers: don't mutate unref list while iterating it

    Commit 934bfe2 had introduced a
    regression where node would crash trying to access a null unref timer if
    a given unref timer's callback would remove other unref timers set to
    fire in the future.
    
    More generally, it makes the unrefTimeout function more solid by not
    mutating the unrefList while traversing it.
    
    Fixes #8897.
    
    Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Julien Gilli committed Dec 22, 2014
    Copy the full SHA
    fd2cb7c View commit details
    Browse the repository at this point in the history