Comparable#== raises SystemStackError when calling classes don't impleme... #2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but you might as well remove the catch of StackOverflowError now. No need to make a new pull request, just make the change and push again :-) |
|
@headius, interesting, thanks so much for the feedback. What code raises the ruby-land SSE then? |
|
Also, there have been some failing tests. Are these expected? |
|
Finally circling back to PRs... Test should be generally green on master now. This were in flux during November and December. The patch is ok, but it doesn't pay attention to the recursion guard's "recur" argument (the boolean you have named |
|
#3006 fixed that |
|
closing since #3006 has been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...nt #<=>
Using recursive pattern