Skip to content

Commit 44304e5

Browse files
committedSep 22, 2012
filter_api: replace implicit join with left join
Fixes #6809: 0005598: Using an 'Or' filter logic
1 parent e054209 commit 44304e5

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed
 

‎core/filter_api.php

+1-2
Original file line numberDiff line numberDiff line change
@@ -1824,8 +1824,7 @@ function filter_get_bug_rows( &$p_page_number, &$p_per_page, &$p_page_count, &$p
18241824
if( !filter_field_is_any( $t_filter[FILTER_PROPERTY_NOTE_USER_ID] ) ) {
18251825
$t_bugnote_table_alias = 'mbnt';
18261826
$t_clauses = array();
1827-
array_push( $t_from_clauses, "$t_bugnote_table $t_bugnote_table_alias" );
1828-
array_push( $t_where_clauses, "( $t_bug_table.id = $t_bugnote_table_alias.bug_id )" );
1827+
array_push( $t_join_clauses, "LEFT JOIN $t_bugnote_table $t_bugnote_table_alias ON $t_bug_table.id = $t_bugnote_table_alias.bug_id" );
18291828

18301829
foreach( $t_filter[FILTER_PROPERTY_NOTE_USER_ID] as $t_filter_member ) {
18311830
$c_note_user_id = db_prepare_int( $t_filter_member );

0 commit comments

Comments
 (0)