Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 62c7fbcd2fc8
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 5962d4a138e1
Choose a head ref
  • 17 commits
  • 51 files changed
  • 1 contributor

Commits on Dec 5, 2014

  1. Add-on init: Dispatch signature on compile time

    Handle different init() signatures in a generic and type safe way. An adapter is selected at compile-time based on the signature of the init function. The adapter is stored in the module struct. At run-time the adapter unpacks the users init function and provides the requested arguments.
    agnat committed Dec 5, 2014
    Copy the full SHA
    a834bcb View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    e28632d View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    585c73a View commit details
    Browse the repository at this point in the history
  4. Add-on init: Cleaned up internal module init

    Passing unused parameters isn't necessary any longer.
    agnat committed Dec 5, 2014
    Copy the full SHA
    deb6453 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    d6d1a31 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    a338d7c View commit details
    Browse the repository at this point in the history
  7. Add-on init: relinted

    agnat committed Dec 5, 2014
    Copy the full SHA
    cae00dc View commit details
    Browse the repository at this point in the history
  8. Add-on init: polishing

    Cosmetics and corner case tests, like the void init function.
    agnat committed Dec 5, 2014
    Copy the full SHA
    af61a24 View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    3dbf1b9 View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    e53eef5 View commit details
    Browse the repository at this point in the history
  11. Copy the full SHA
    2c73193 View commit details
    Browse the repository at this point in the history
  12. Add-on init: Simplified OptionalInitArg

    Replaced operator() with a plain static member function.
    agnat committed Dec 5, 2014
    Copy the full SHA
    c4dca9e View commit details
    Browse the repository at this point in the history
  13. Add-on init: Touch-ups

    Renamed struct field 'init' to 'nm_init'.
    agnat committed Dec 5, 2014
    Copy the full SHA
    ec680a0 View commit details
    Browse the repository at this point in the history
  14. Add-on init: Removed "private" argument

    The private argument is pretty useless since it is restricted to a compile-time constant. The only place to access this constant private value is the init function. This really makes no sense. Removing.
    agnat committed Dec 5, 2014
    Copy the full SHA
    8e2dcdf View commit details
    Browse the repository at this point in the history
  15. Revert "Add-on init: Removed "private" argument"

    This reverts commit dff8b1b.
    agnat committed Dec 5, 2014
    Copy the full SHA
    3c20df8 View commit details
    Browse the repository at this point in the history
  16. Add-on init: Refactor after review by @indutny

    * do not attempt to inline registerAddon
    * removed C++11 variant
    * diff hygiene: respect line ownership in macros
    * cosmetics
    agnat committed Dec 5, 2014
    Copy the full SHA
    42b14a1 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2014

  1. Add-on init: Fix mess left after rebase

    Not sure how, but apparently I lost some changes in the rebase yesterday. Also not sure how I didn't notice. Anyway, this should do it.
    agnat committed Dec 6, 2014
    Copy the full SHA
    5962d4a View commit details
    Browse the repository at this point in the history