Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRUNK-4298 Unexpected Error pops up while navigating through the concept... #742

Closed
wants to merge 3 commits into from

Conversation

ShubhamRai
Copy link
Contributor

...s

@dkayiwa
Copy link
Member

dkayiwa commented Mar 10, 2014

@ShubhamRai can you also indent your if statements to make them more readable?

@ShubhamRai
Copy link
Contributor Author

@dkayiwa The legend for concept resources is visible but the one of concept usage is not as the concept does not exist.Should I create a new pull request?

@dkayiwa
Copy link
Member

dkayiwa commented Mar 10, 2014

@ShubhamRai which one will be easier for you? A new pull request? Or another commit?
Even if the concept does not exist, still show the legend as it is done for the other section above it.

@ShubhamRai
Copy link
Contributor Author

@dkayiwa Now the legend is getting displayed and I have also indented the code.I am not creating a new pr.If required kindly say so.

@dkayiwa
Copy link
Member

dkayiwa commented Mar 10, 2014

Go ahead!

On Mon, Mar 10, 2014 at 3:28 PM, Shubham Rai notifications@github.comwrote:

@dkayiwa https://github.com/dkayiwa Now the legend is getting displayed
and I have also indented the code.I am not creating a new pr.If required
kindly say so.

Reply to this email directly or view it on GitHubhttps://github.com//pull/742#issuecomment-37176874
.

If we keep uppermost in our minds the unkind and unjust acts of others, we
shall find it impossible to love them as Christ has loved us; but if our
thoughts dwell upon the wondrous love and pity of Christ for us, the same
spirit will flow out to others.

@ShubhamRai ShubhamRai closed this Mar 10, 2014
@ShubhamRai ShubhamRai deleted the TRUNK-4298 branch March 10, 2014 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants