Update tests that extract RDF graphs from responses to: #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cbeer
commented
Nov 7, 2013
cbeer
commented
- validate it receives RDF
- select an appropriate RDF serialization for the Content-Type
- consistently fetch the graph using test helpers
|
@awoods ? |
|
Is there a ticket for this? ...mostly because tickets help establish an accurate velocity. |
|
This falls under part of the Jersey 2.x migration (https://www.pivotaltracker.com/story/show/52200823). There isn't a stand-alone ticket, no. |
| new HttpPost(txLocation + "/object-in-tx-rollback"); | ||
| HttpResponse resp = execute(postNew); | ||
| assertEquals(201, resp.getStatusLine().getStatusCode()); | ||
| execute(new HttpPost(txLocation + "/object-in-tx-rollback")); |
There was a problem hiding this comment.
Is the status-code check removed because it was failing? or is there another reason for not inspecting the HttpResponse?
|
Ready to go, pending minor comments. |
|
I can restore those checks if you want. It's not clear that we care about the response, or in what circumstances it'd actually fail. |
|
They are simple checks. Please feel free to re-add and commit/merge. |
|
Will do. |
- validate it receives RDF - select an appropriate RDF serialization for the Content-Type - consistently fetch the graph using test helpers
|
Done, and rebased. |
awoods
pushed a commit
that referenced
this pull request
Nov 13, 2013
Update tests that extract RDF graphs from responses to:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.