Elkpr/426 #441
Merged
Elkpr/426 #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the query from loadAttachmentContext() and put it in that new function Still not sure if this should auto-handle the attachment directories Signed-off-by:Joshua Dickerson <joshua.a.dickerson@gmail.com>
Signed-off-by:Joshua Dickerson <joshua.a.dickerson@gmail.com>
Signed-off-by:Joshua Dickerson <joshua.a.dickerson@gmail.com>
…tach. Signed-off-by: Norv <a.w.norv@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have rebased #426 to the updated master, and added a few fixes from https://github.com/joshuaadickerson/NotElkarte/tree/AttachmentThumb_new.
(This last branch was not rebased to master yet, when I fixed this PR.)
IMO, this is a very good (re)start on the (very spread out everywhere) attachments code. And it should be improved further. For example, add automanagement for updates that create a new thumbnail, and split out thumbnail creation in createAttachments. Also, we can eventually improve implementation when the needs of the code are more clear.
I think I would rather accept it though, and continue reimplementation of them attachments.