add spec for inline rescue #3273
Conversation
|
A few questions/remarks:
|
| @@ -0,0 +1,9 @@ | |||
| require File.expand_path('../../../shared/kernel/raise', __FILE__) | |||
|
|
|||
| describe "inline rescue" do | |||
There was a problem hiding this comment.
Since at its core this spec is testing if ||= works correctly with a rescue, I'd say this description should be something along the lines of "Optional assignments".
There was a problem hiding this comment.
Ah, this exists: https://github.com/rubinius/rubinius/blob/master/spec/ruby/language/variables_spec.rb#L4
Since this file is already pretty big I'd suggest putting the specs in spec/ruby/language/optional_assignments_spec.rb, otherwise they can be added as an extra describe block in this existing file.
|
Should there be a tag? Don't we know this is going to fail? |
| require File.expand_path('../../../shared/kernel/raise', __FILE__) | ||
|
|
||
| describe "inline rescue" do | ||
| it "properly executes compound assignment operators" do |
There was a problem hiding this comment.
This should be something along the lines of "does not overwrite a variable when using an inline rescue". The idea is to clearly state that:
- The spec should do something that doesn't overwrite a value
- This should not occur when using an inline rescue
|
Sorry, I didn't mean for this pull request to be taken as is. I just wanted to trigger a travis build to show the failure. Sorry not to be clear about that. I'm really not familiar with rubinious or how it is organized. Unless you really need my assistance, I hope you and other contributors can take it from here. Thanks. |
|
@dontfidget Ah ok, that's perfectly fine as well. Thanks for at least looking into this :) |
Demonstrate the failure in #3272